[GitHub] [flink] aljoscha commented on a change in pull request #8982: [FLINK-13098][datastream] Add a new type UNDEFINED of shuffle mode

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #8982: [FLINK-13098][datastream] Add a new type UNDEFINED of shuffle mode
URL: https://github.com/apache/flink/pull/8982#discussion_r300659561
 
 

 ##########
 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
 ##########
 @@ -385,24 +386,38 @@ public void testInputOutputFormat() {
 	@Test
 	public void testShuffleMode() {
 		StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
-		// fromElements -> Map -> Print, will not chain since the batch data exchange mode
-		DataStream<Integer> mapDataStream = env.fromElements(1, 2, 3)
-			.map((MapFunction<Integer, Integer>) value -> value).setParallelism(2);
+		// fromElements -> Filter -> Map -> Print
 
 Review comment:
   Usually, I like to split these tests up, so that each test checks one isolated thing. The structure of each test would be roughly:
   ```
   void testSomething() {
      //setup
     
      //action
   
      //verification
   }
   ```
   
   Otherwise, the whole test has to be touched whenever we change something for one of the scheduling modes or the scheduling logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services