You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/07/11 16:18:00 UTC
Re: svn commit: r32063 - trunk/subversion/libsvn_wc
julianfoad@tigris.org writes:
> --- trunk/subversion/libsvn_wc/props.c (r32062)
> +++ trunk/subversion/libsvn_wc/props.c (r32063)
> @@ -1186,6 +1186,27 @@ set_prop_merge_state(svn_wc_notify_state
> }
>
>
> +/* Create a temporary file in the same directory as PATH. Fill it with
> + * the data in VAL. Set *NEW_FILE to its handle and *NEW_PATH to its path.
> + * Allocate the file metadata in POOL in such a way that the file will be
> + * deleted when the pool is cleared. */
> +static svn_error_t *
> +write_tmp_file(const char **new_path,
> + const char *path, const svn_string_t *val,
> + apr_pool_t *pool)
> +{
There is no parameter NEW_FILE here...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32063 - trunk/subversion/libsvn_wc
Posted by Julian Foad <ju...@btopenworld.com>.
Senthil Kumaran S wrote:
> Julian Foad wrote:
> > On Fri, 2008-07-11 at 12:18 -0400, Karl Fogel wrote:
> >>> +/* Create a temporary file in the same directory as PATH. Fill it with
> >>> + * the data in VAL. Set *NEW_FILE to its handle and *NEW_PATH to its path.
> >>> + * Allocate the file metadata in POOL in such a way that the file will be
> >>> + * deleted when the pool is cleared. */
> >>> +static svn_error_t *
> >>> +write_tmp_file(const char **new_path,
> >>> + const char *path, const svn_string_t *val,
> >>> + apr_pool_t *pool)
> >>> +{
> >> There is no parameter NEW_FILE here...
> >
> > Thanks. Fixed in r32077.
>
> Do we need "Suggested by:" clause for 32077?
No, I don't think so. The benefits of recording who suggested a change
are to give them credit for their suggestion, and so we can contact them
if we later have questions about it or need help in testing it. These
sorts of benefits do not exist for an obvious and trivial fix.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32063 - trunk/subversion/libsvn_wc
Posted by Senthil Kumaran S <se...@collab.net>.
Julian Foad wrote:
> On Fri, 2008-07-11 at 12:18 -0400, Karl Fogel wrote:
>> julianfoad@tigris.org writes:
>>> --- trunk/subversion/libsvn_wc/props.c (r32062)
>>> +++ trunk/subversion/libsvn_wc/props.c (r32063)
>>> @@ -1186,6 +1186,27 @@ set_prop_merge_state(svn_wc_notify_state
>>> }
>>>
>>>
>>> +/* Create a temporary file in the same directory as PATH. Fill it with
>>> + * the data in VAL. Set *NEW_FILE to its handle and *NEW_PATH to its path.
>>> + * Allocate the file metadata in POOL in such a way that the file will be
>>> + * deleted when the pool is cleared. */
>>> +static svn_error_t *
>>> +write_tmp_file(const char **new_path,
>>> + const char *path, const svn_string_t *val,
>>> + apr_pool_t *pool)
>>> +{
>> There is no parameter NEW_FILE here...
>
> Thanks. Fixed in r32077.
Do we need "Suggested by:" clause for 32077?
--
Senthil Kumaran S
http://www.stylesen.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r32063 - trunk/subversion/libsvn_wc
Posted by Julian Foad <ju...@btopenworld.com>.
On Fri, 2008-07-11 at 12:18 -0400, Karl Fogel wrote:
> julianfoad@tigris.org writes:
> > --- trunk/subversion/libsvn_wc/props.c (r32062)
> > +++ trunk/subversion/libsvn_wc/props.c (r32063)
> > @@ -1186,6 +1186,27 @@ set_prop_merge_state(svn_wc_notify_state
> > }
> >
> >
> > +/* Create a temporary file in the same directory as PATH. Fill it with
> > + * the data in VAL. Set *NEW_FILE to its handle and *NEW_PATH to its path.
> > + * Allocate the file metadata in POOL in such a way that the file will be
> > + * deleted when the pool is cleared. */
> > +static svn_error_t *
> > +write_tmp_file(const char **new_path,
> > + const char *path, const svn_string_t *val,
> > + apr_pool_t *pool)
> > +{
>
> There is no parameter NEW_FILE here...
Thanks. Fixed in r32077.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org