You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (Created) (JIRA)" <ji...@apache.org> on 2012/04/02 15:31:24 UTC
[jira] [Created] (BOOKKEEPER-207) BenchBookie doesn't run correctly
BenchBookie doesn't run correctly
---------------------------------
Key: BOOKKEEPER-207
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Fix For: 4.1.0
Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-207) BenchBookie doesn't run correctly
Posted by "Ivan Kelly (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-207:
----------------------------------
Attachment: BOOKKEEPER-207.diff
Fix makes the benchmark create a ledger to write to. This prevents GC from interfering.
> BenchBookie doesn't run correctly
> ---------------------------------
>
> Key: BOOKKEEPER-207
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-207.diff
>
>
> Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-207) BenchBookie doesn't run
correctly
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245486#comment-13245486 ]
Hudson commented on BOOKKEEPER-207:
-----------------------------------
Integrated in bookkeeper-trunk #444 (See [https://builds.apache.org/job/bookkeeper-trunk/444/])
BOOKKEEPER-207: BenchBookie doesn't run correctly (ivank via fpj) (Revision 1309007)
Result = SUCCESS
fpj :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/BenchBookie.java
* /zookeeper/bookkeeper/trunk/bookkeeper-benchmark/src/test/java/org/apache/bookkeeper/benchmark/TestBenchmark.java
> BenchBookie doesn't run correctly
> ---------------------------------
>
> Key: BOOKKEEPER-207
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-207.diff
>
>
> Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-207) BenchBookie doesn't run
correctly
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244186#comment-13244186 ]
Flavio Junqueira commented on BOOKKEEPER-207:
---------------------------------------------
It looks mostly good, I just have one small question. In trunk, we refer to ledger+1 and ledger+2, which seems to imply that we are writing to different ledgers. Your patch makes it uniform. Is it the right behavior?
> BenchBookie doesn't run correctly
> ---------------------------------
>
> Key: BOOKKEEPER-207
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-207.diff
>
>
> Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-207) BenchBookie doesn't run
correctly
Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244196#comment-13244196 ]
Ivan Kelly commented on BOOKKEEPER-207:
---------------------------------------
I generate a new ledger for each of the runs, so the value is different in each.
> BenchBookie doesn't run correctly
> ---------------------------------
>
> Key: BOOKKEEPER-207
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-207.diff
>
>
> Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-207) BenchBookie doesn't run
correctly
Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244204#comment-13244204 ]
Flavio Junqueira commented on BOOKKEEPER-207:
---------------------------------------------
True, thanks for the clarification, +1.
> BenchBookie doesn't run correctly
> ---------------------------------
>
> Key: BOOKKEEPER-207
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-207
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-207.diff
>
>
> Bench bookie tests latency of addEntry to a single bookie. Currently it simply writes to a specified ledger id. If this ledger id doesn't exist in zookeeper, the ledger is GC'd from the bookie and errors occur in the bench.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira