You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/15 02:26:19 UTC
[GitHub] [incubator-inlong] luchunliang opened a new pull request #3138: [INLONG-3136] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
luchunliang opened a new pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138
### Title Name: [INLONG-3136][Manager] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
Fixes #3136
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #3138: [INLONG-3136][DataProxy] get "NOUPDATE" configuration from Manager when request md5 is same.
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3138: [INLONG-3136] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138#discussion_r826531302
##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/RemoteConfigManager.java
##########
@@ -143,8 +143,12 @@ public void reload() {
//
this.ipListParser.setCommonProperties(ConfigManager.getInstance().getCommonProperties());
List<String> managerIpList = this.ipListParser.getIpList();
+ if (managerIpList == null || managerIpList.size() == 0) {
+ return;
Review comment:
directly return， but does not print log "end to reload config".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3138: [INLONG-3136] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138#discussion_r826537924
##########
File path: inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/RemoteConfigManager.java
##########
@@ -143,8 +143,12 @@ public void reload() {
//
this.ipListParser.setCommonProperties(ConfigManager.getInstance().getCommonProperties());
List<String> managerIpList = this.ipListParser.getIpList();
+ if (managerIpList == null || managerIpList.size() == 0) {
+ return;
Review comment:
add error log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3138: [INLONG-3136] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138#discussion_r826529610
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/DataProxyClusterServiceImpl.java
##########
@@ -42,15 +44,32 @@
* @return data proxy config
*/
public String getAllConfig(String clusterName, String setName, String md5) {
+ log.error("proxyRepository.getClusterSets():{}", new Gson().toJson(proxyRepository.getClusterSets()));
DataProxyClusterSet setObj = proxyRepository.getDataProxyClusterSet(setName);
+ log.error("proxyRepository.getClusterSets().size():{}, setName:{}, setObj:{}",
+ proxyRepository.getClusterSets().size(), setName, setObj);
if (setObj == null) {
return this.getErrorAllConfig();
}
String configMd5 = setObj.getMd5Map().get(clusterName);
- if (configMd5 == null || !configMd5.equals(md5)) {
+ log.error("setObj.getMd5Map().size():{}, clusterName:{}, configMd5:{}", setObj.getMd5Map().size(),
Review comment:
why use error level log here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3138: [INLONG-3136] DataProxy get "NOUPDATE" configuration from Manager when request md5 is same.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #3138:
URL: https://github.com/apache/incubator-inlong/pull/3138#discussion_r826537841
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/DataProxyClusterServiceImpl.java
##########
@@ -42,15 +44,32 @@
* @return data proxy config
*/
public String getAllConfig(String clusterName, String setName, String md5) {
+ log.error("proxyRepository.getClusterSets():{}", new Gson().toJson(proxyRepository.getClusterSets()));
DataProxyClusterSet setObj = proxyRepository.getDataProxyClusterSet(setName);
+ log.error("proxyRepository.getClusterSets().size():{}, setName:{}, setObj:{}",
+ proxyRepository.getClusterSets().size(), setName, setObj);
if (setObj == null) {
return this.getErrorAllConfig();
}
String configMd5 = setObj.getMd5Map().get(clusterName);
- if (configMd5 == null || !configMd5.equals(md5)) {
+ log.error("setObj.getMd5Map().size():{}, clusterName:{}, configMd5:{}", setObj.getMd5Map().size(),
Review comment:
remove error log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org