[GitHub] sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug

[GitBox <gi...@apache.org>]

sankarh commented on a change in pull request #388: HIVE-20057: Fix Hive table conversion DESCRIBE table bug
URL: https://github.com/apache/hive/pull/388#discussion_r261195039
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 ##########
 @@ -1802,12 +1802,12 @@ private MTable convertToMTable(Table tbl) throws InvalidObjectException,
     // accordingly
     String tableType = tbl.getTableType();
     boolean isExternal = Boolean.parseBoolean(tbl.getParameters().get("EXTERNAL"));
-    if (TableType.MANAGED_TABLE.toString().equals(tableType)) {
+    if (TableType.MANAGED_TABLE.toString().equalsIgnoreCase(tableType)) {
 
 Review comment:
   I think, this issue doesn't exist in master code.
   We use Boolean.parseBoolean to read the "EXTERNAL" property which ignores case. Also, the fix in the patch is to use equalsIgnoreCase when compare the TableType and not "EXTERNAL" property which is irrelevant.
   If I misunderstood your scenario, please let me know.
   Also, it would be better to add a unit test to reproduce this bug in master code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services