You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/10 08:49:04 UTC
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1042: chore(build): remove some cpp files auto generated by thrift
acelyc111 commented on code in PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#discussion_r917228629
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -409,3 +409,13 @@ ExternalProject_Add(http-parser
INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h
BUILD_IN_SOURCE 1
)
+
+# ExternalProject_Add(python
+# URL ${OSS_URL_PREFIX}/Python-2.7.18.tgz
+# https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
Review Comment:
python has been installed on each Dockerfile, no need to installed again. See
https://github.com/apache/incubator-pegasus/blob/master/docker/pegasus-build-env/centos7/Dockerfile#L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org