You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Piotr Zygielo (Jira)" <ji...@apache.org> on 2021/07/06 08:22:00 UTC

[jira] [Commented] (MCHECKSTYLE-406) Make plugin compatible with Checkstyle 8.44

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375346#comment-17375346 ] 

Piotr Zygielo commented on MCHECKSTYLE-406:
-------------------------------------------

The CS-plugin is configured to use CS 8.41.1, which works fine.

aspectj-maven-plugin is overriding this dependency - IMO it shall also be responsible for providing proper, up to date, CS configuration.

 

 

As the project aspectj-maven-plugin is not using customised CS config location, but the one configured in its parent
{quote}<configLocation>config/maven_checks.xml</configLocation> <!-- org.codehaus.mojo:mojo-parent:63, line 270 -->
{quote}
and a-m-p is not providing customised configuration but
{quote}[DEBUG] The resource 'config/maven_checks.xml' was found as jar:file:.../m2/repository/org/apache/maven/shared/maven-shared-resources/3/maven-shared-resources-3.jar!/config/maven_checks.xml.
{quote}
is used.

Sounds like https://issues.apache.org/jira/browse/MSHARED-990

> Make plugin compatible with Checkstyle 8.44
> -------------------------------------------
>
>                 Key: MCHECKSTYLE-406
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-406
>             Project: Maven Checkstyle Plugin
>          Issue Type: Dependency upgrade
>    Affects Versions: 3.1.2
>            Reporter: Alexander Kriegisch
>            Priority: Major
>
> On GitHub, Dependabot suggests upgrading Checkstyle to something more recent than 8.41.1, but the corresponding builds fail, both for 8.43 and 8.44, e.g. [this build|https://github.com/dev-aspectj/aspectj-maven-plugin/pull/20/checks?check_run_id=2933248023]:
> {code}
> Error:  Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on project aspectj-maven-plugin: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report: Failed during checkstyle configuration: cannot initialize module TreeWalker - cannot initialize module JavadocMethod - Property 'scope' does not exist, please check the documentation -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on project aspectj-maven-plugin: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
>     (...)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error generating maven-checkstyle-plugin:3.1.2:checkstyle report
>     at org.apache.maven.plugins.site.render.SiteMojo.execute (SiteMojo.java:151)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210)
>     (...)
> Caused by: org.apache.maven.reporting.MavenReportException: Failed during checkstyle configuration
>     at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure (AutomaticBean.java:201)
>     at org.apache.maven.plugins.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle (DefaultCheckstyleExecutor.java:167)
>     at org.apache.maven.plugins.checkstyle.AbstractCheckstyleReport.executeReport (AbstractCheckstyleReport.java:533)
>     (...)
> {code}
> This is in no way urgent, but as Dependabot keeps bugging me with this for every new Checkstyle version, I thought I should mention it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)