You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Manno15 (via GitHub)" <gi...@apache.org> on 2023/04/15 17:48:57 UTC

[GitHub] [accumulo-website] Manno15 commented on a diff in pull request #383: Fix Teardown documentation

Manno15 commented on code in PR #383:
URL: https://github.com/apache/accumulo-website/pull/383#discussion_r1167593585


##########
_docs-2/development/iterators.md:
##########
@@ -408,12 +408,16 @@ On an instance of an Iterator: `init` is always called before `seek`, `seek` is
 
 ### Teardown
 
-As mentioned, instance of Iterators may be torn down inside of the server transparently. When a complex
-collection of iterators is performing some advanced functionality, they will not be torn down until a Key-Value
-pair is returned out of the "stack" of Iterators (and added into the batch of Key-Values to be returned
-to the caller). Being torn-down is equivalent to a new instance of the Iterator being creating and `deepCopy`
-being called on the new instance with the old instance provided as the argument to `deepCopy`. References
-to the old instance are removed and the object is lazily garbage collected by the JVM.
+Instances of iterators may be torn down inside the server transparently. When a complex collection
+of iterators is performing advanced functionality, they will not be torn down until a Key-Value pair
+is returned out of the "stack" of iterators (and added into the batch of Key-Values to be returned
+to the caller), or the iterator is yielded.
+
+When an iterator is torn down, the entire stack is dropped and no state is preserved. Only the last
+key returned (or the yielded position), original options, and seek range are retained. When the scan
+is continued, the iterator stack is rebuilt, re-initialized using the original options. The stack
+is then seeked with the original range, and the start key is replaced by the last key returned (or

Review Comment:
   ```suggestion
   key returned (or the yielded position), original options, and seek range are retained. When the scan
   is continued, the iterator stack is rebuilt and re-initialized using the original options. The stack
   is then seeked with the original range, and the start key is replaced by the last key returned (or
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org