You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by vk...@apache.org on 2008/09/10 10:50:24 UTC
svn commit: r693739 -
/portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java
Author: vkumar
Date: Wed Sep 10 01:50:24 2008
New Revision: 693739
URL: http://svn.apache.org/viewvc?rev=693739&view=rev
Log:
Optimizing portlet functionality with new security API's
Modified:
portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java
Modified: portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java?rev=693739&r1=693738&r2=693739&view=diff
==============================================================================
--- portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java (original)
+++ portals/jetspeed-2/applications/j2-admin/branches/security-refactoring/src/main/java/org/apache/jetspeed/portlets/security/users/GroupChooserPortlet.java Wed Sep 10 01:50:24 2008
@@ -16,22 +16,19 @@
*/
package org.apache.jetspeed.portlets.security.users;
-import java.security.Principal;
-import java.sql.Types;
-import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.List;
-
-import javax.portlet.PortletConfig;
-import javax.portlet.PortletException;
-import javax.portlet.RenderRequest;
-
-import org.apache.jetspeed.CommonPortletServices;
-import org.apache.jetspeed.security.Group;
-import org.apache.jetspeed.security.GroupManager;
-import org.apache.portals.gems.browser.BrowserIterator;
-import org.apache.portals.gems.browser.DatabaseBrowserIterator;
-import org.apache.portals.gems.browser.BrowserPortlet;
+import java.sql.Types;
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.portlet.PortletConfig;
+import javax.portlet.PortletException;
+import javax.portlet.RenderRequest;
+
+import org.apache.jetspeed.CommonPortletServices;
+import org.apache.jetspeed.security.GroupManager;
+import org.apache.portals.gems.browser.BrowserIterator;
+import org.apache.portals.gems.browser.BrowserPortlet;
+import org.apache.portals.gems.browser.DatabaseBrowserIterator;
/**
* GroupChooserPortlet
@@ -62,22 +59,10 @@
List resultSetTypeList = new ArrayList();
try
{
- Iterator groups = groupManager.getGroups("").iterator();
-
-
resultSetTypeList.add(String.valueOf(Types.VARCHAR));
- resultSetTitleList.add("Group");
-
- // TODO: need to try to normalize List/Collection/Iterators
- List list = new ArrayList();
- while (groups.hasNext())
- {
- Group group = (Group)groups.next();
-
- //Principal principal = group.getPrincipal();
- //list.add(principal.getName());
- list.add(group.getName());
- }
+ resultSetTitleList.add("Group");
+
+ List<String> list = groupManager.getGroupNames("");
BrowserIterator iterator = new DatabaseBrowserIterator(
list, resultSetTitleList, resultSetTypeList,
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org