You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2014/07/28 20:24:39 UTC
[jira] [Comment Edited] (LOG4J2-744) Avoid unnecessary Clock calls
when TimestampMessage is logged
[ https://issues.apache.org/jira/browse/LOG4J2-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076154#comment-14076154 ]
Gary Gregory edited comment on LOG4J2-744 at 7/28/14 6:22 PM:
--------------------------------------------------------------
{quote}
I don't think this use case is strong enough to justify an API change.
{quote}
I think it is fair to ask first if it is the best solution. If it is, we can talk about when to implement it or discuss an alternative is the API is to disruptive for current users (with "disruptive" not defined to strictly BC).
was (Author: garydgregory):
{quote}
I don't think this use case is strong enough to justify an API change.
{quote}
I think it is fail to ask first if it is the best solution. If it is, we can talk about when to implement it or discuss an alternative is the API is to disruptive for current users (with "disruptive" not defined to strictly BC).
> Avoid unnecessary Clock calls when TimestampMessage is logged
> -------------------------------------------------------------
>
> Key: LOG4J2-744
> URL: https://issues.apache.org/jira/browse/LOG4J2-744
> Project: Log4j 2
> Issue Type: Improvement
> Reporter: Scott Harrington
> Priority: Minor
> Attachments: LOG4J2-744-test.patch, LOG4J2-744.patch
>
>
> The TimestampMessage interface was introduced in LOG4J2-53 and revised for AsyncLogger in LOG4J2-455.
> I've observed that Clock.currentTimeMillis is still called which should not be necessary.
> I have two patches, one which adds JUnit tests that demonstrate the unnecessary Clock calls, and one which fixes the issue for both AsyncLogger and "traditional" configurations.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org