You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2010/08/26 20:13:57 UTC
[jira] Created: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Take advantage of Avro IDL includes
-----------------------------------
Key: CASSANDRA-1436
URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Stu Hood
Fix For: 0.7.0
Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904821#action_12904821 ]
Stu Hood commented on CASSANDRA-1436:
-------------------------------------
Gary pointed out that since we aren't dealing with identical schemas, removing the duplication might be impossible. But Doug pointed out that Avro 1.4 supports aliasing: "so you can alias a schema into another namespace so it will resolve.". Still, potentially painful and ugly.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Fix For: 0.7.0
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915842#action_12915842 ]
Stu Hood commented on CASSANDRA-1436:
-------------------------------------
(We needed an Avro upgrade to get the IDL alias support from 634: it's included in the second patch, but versions of trunk built after September 13th should work.)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918495#action_12918495 ]
Hudson commented on CASSANDRA-1436:
-----------------------------------
Integrated in Cassandra #557 (See [https://hudson.apache.org/hudson/job/Cassandra/557/])
use avro includes and aliases in order to have less duplicated structures. patch by stuhood, reviewed by gdusbabek. CASSANDRA-1436
use avro includes and aliases in order to have less duplicated structures. patch by stuhood, reviewed by gdusbabek. CASSANDRA-1436
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch, avro-1.4.0-sources.jar, avro-1.4.0.jar
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch
0002-Add-aliases-and-remove-duplicated-classes.patch
Uses AVRO-495 and AVRO-634 to remove the duplication between the client interface protocol and the internal protocol.
Tested with an upgrade from 0.7-beta1 to 0.7-beta2.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood reassigned CASSANDRA-1436:
-----------------------------------
Assignee: Gary Dusbabek (was: Stu Hood)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch, avro-1.5.0-SNAPSHOT~r999556.jar
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905193#action_12905193 ]
Stu Hood commented on CASSANDRA-1436:
-------------------------------------
In order to use aliases with genavro IDLs, we need AVRO-634.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Fix For: 0.7.0
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917986#action_12917986 ]
Gary Dusbabek commented on CASSANDRA-1436:
------------------------------------------
This patch looks good. +1
Are there any objections upgrading to to a trunk snapshot of Avro?
I don't know that I favor it, but the only objection I can come with is "it's unreleased," which isn't much of an objection. Unless there are stronger opinions, I'll commit this at the end of the day.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch, avro-1.5.0-SNAPSHOT~r999556.jar
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch
0002-Add-aliases-and-remove-duplicated-classes.patch
avro-1.5.0-SNAPSHOT~r999556.jar
Separated out the updated Avro jar, and rebased for trunk.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch, avro-1.5.0-SNAPSHOT~r999556.jar
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917074#action_12917074 ]
Gary Dusbabek commented on CASSANDRA-1436:
------------------------------------------
tests fail to build after a realclean:
build-test:
[javac] Compiling 88 source files to /Users/gary.dusbabek/codes/apache/git-trunk/build/test/classes
[javac] /Users/gary.dusbabek/codes/apache/git-trunk/test/unit/org/apache/cassandra/config/DatabaseDescriptorTest.java:62: package org.apache.cassandra.config.avro does not exist
[javac] CFMetaData cfmDupe = CFMetaData.inflate(serDe(cfm.deflate(), new org.apache.cassandra.config.avro.CfDef()));
[javac] ^
[javac] /Users/gary.dusbabek/codes/apache/git-trunk/test/unit/org/apache/cassandra/config/DatabaseDescriptorTest.java:74: package org.apache.cassandra.config.avro does not exist
[javac] KSMetaData ksmDupe = KSMetaData.inflate(serDe(ksm.deflate(), new org.apache.cassandra.config.avro.KsDef()));
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 2 errors
BUILD FAILED
/Users/gary.dusbabek/codes/apache/git-trunk/build.xml:412: Compile failed; see the compiler error output for details.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1436:
--------------------------------------
Fix Version/s: (was: 0.7.0)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: avro-1.4.0.jar
avro-1.4.0-sources.jar
Attaching a 1.4+634 jar, with source: passes unit and system tests.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch, avro-1.4.0-sources.jar, avro-1.4.0.jar
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: (was: 0002-Add-aliases-and-remove-duplicated-classes.patch)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Fix Version/s: 0.7.0
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: 0002-Add-aliases-and-remove-duplicated-classes.patch
Rebased.
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: (was: avro-1.5.0-SNAPSHOT~r999556.jar)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Gary Dusbabek
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: (was: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1436) Take advantage of Avro IDL
includes
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-1436:
--------------------------------
Attachment: (was: 0002-Add-aliases-and-remove-duplicated-classes.patch)
> Take advantage of Avro IDL includes
> -----------------------------------
>
> Key: CASSANDRA-1436
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1436
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.0
>
> Attachments: 0001-Use-Avro-includes-involves-one-additional-Avro-code-.patch, 0002-Add-aliases-and-remove-duplicated-classes.patch
>
>
> Cassandra is currently using duplicated records for (Ks|Cf|*)Def in the public and private protocols: taking advantage of AVRO-495 would allow us to remove this duplication.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.