You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/15 09:29:59 UTC
[PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
gnodet opened a new pull request, #26456:
URL: https://github.com/apache/camel/pull/26456
## Summary
Fix inconsistent URL-encoding of kamelet parameters when using `toD` vs `to` (CAMEL-24747).
## Root Cause
When `SendDynamicProcessor` (used by `toD`) resolves a dynamic endpoint, `prepareRecipient()` wraps the URI in a `NormalizedUri` — which stores the URL-normalized (encoded) form. This `NormalizedUri` is then passed through `DefaultCamelContextExtension.getEndpoint(NormalizedEndpointUri)` to `doGetEndpoint()` with `normalized=true`.
In `doGetEndpoint`, when `normalized=true`, `rawUri` is set to the already-encoded `uri` string before the component check. The line:
```java
answer = component.createEndpoint(
component.useRawUri() ? rawUri : uri,
parameters);
```
…therefore passes the **encoded** URI to `KameletComponent` even though it declares `useRawUri()=true`. Parameter values like `http://example.com?key=abc%+def` arrive as `http%3A%2F%2Fexample.com%3Fkey%3Dabc%25%2Bdef`.
The static `to` DSL is unaffected because it calls `doGetEndpoint(uri, null, false, false)` (i.e. `normalized=false`), so `rawUri` is captured **before** normalization.
## Fix
Extended `NormalizedUri` with a `rawUri` field that preserves the original un-normalized URI alongside the normalized form used for endpoint cache keys. `DefaultCamelContextExtension.getEndpoint(NormalizedEndpointUri)` now extracts this raw URI and passes it to a new `doGetEndpoint` overload, ensuring `component.useRawUri() ? rawUri : uri` receives the correct un-encoded string.
Files changed:
- `core/camel-support/…/NormalizedUri.java` — add `rawUri` field + `getRawUri()` getter
- `core/camel-base-engine/…/AbstractCamelContext.java` — new `doGetEndpoint` overload with explicit `rawUri` parameter
- `core/camel-base-engine/…/DefaultCamelContextExtension.java` — pass raw URI from `NormalizedUri` through the extension methods
- `components/camel-kamelet/…/KameletToDUrlEncodingTest.java` — regression test
## Test
New test `KameletToDUrlEncodingTest.toDPreservesSpecialCharsLikeTo` verifies that a kamelet parameter containing `%`, `+`, `?`, and `=` (e.g. `http://example.com?key=abc%+def`) is received by the kamelet body expression **unchanged** when invoked via `toD`, matching the result of the static `to` DSL.
Existing test `KameletGlobalPropertiesTest.urlEncodingIsRespected` (which verifies the CAMEL-22511 fix — raw mode for secret values — is preserved) continues to pass.
---
_Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5694801084
<!-- regen-patch -->
### :warning: Generated files are out of date
The [CI build](https://github.com/apache/camel/actions/runs/35075254000) regenerated files that are not committed on this PR.
If *Allow edits from maintainers* is enabled, a maintainer bot will automatically
push a "Regen" commit to this branch shortly.
Otherwise, you can apply the patch manually — the missing changes are available
as the `regen-patch` artifact of that run:
```bash
gh pr checkout 26456 --repo apache/camel
gh run download 35075254000 --repo apache/camel -n regen-patch
git apply --index regen.patch && rm regen.patch pr-number
git commit -m "Regen" && git push
```
Alternatively, run `./etc/scripts/regen.sh` locally and commit the resulting changes.
If the patch does not apply cleanly, update the branch from the base branch first —
the patch was generated against the merge with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710859175
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711053198
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5678548155
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-kamelet`
- `core/camel-base-engine`
- `core/camel-support`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 564 tested, 27 compile-only — current: 564 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **591 affected modules** (current approach: 564).
<details><summary>:warning: Modules only in Scalpel (27)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
**Skip-tests mode would test 564 modules** (3 direct + 561 downstream), **skip tests for 27** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (564)</summary>
- `archetypes`
- `camel-a2a`
- `camel-activemq`
- `camel-activemq6`
- `camel-ai-observability`
- `camel-ai-observability-api`
- `camel-ai-parent`
- `camel-ai-resource`
- `camel-ai-tool`
- `camel-alibaba-common`
- `camel-alibaba-eventbridge`
- `camel-alibaba-fc`
- `camel-alibaba-kms`
- `camel-alibaba-mns`
- `camel-alibaba-oss`
- `camel-alibaba-ots`
- `camel-alibaba-parent`
- `camel-alibaba-sls`
- `camel-alibaba-sms`
- `camel-amqp`
- `camel-api-component-maven-plugin`
- `camel-arangodb`
- `camel-archetype-api-component`
- `camel-archetype-component`
- `camel-archetype-dataformat`
- `camel-archetype-java`
- `camel-archetype-main`
- `camel-as2`
- `camel-as2-api`
- `camel-as2-parent`
- `camel-asn1`
- `camel-asterisk`
- `camel-atmosphere-websocket`
- `camel-atom`
- `camel-attachments`
- `camel-avro`
- `camel-avro-rpc`
- `camel-avro-rpc-jetty`
- `camel-avro-rpc-parent`
- `camel-avro-rpc-spi`
- `camel-aws-bedrock`
- `camel-aws-cloudtrail`
- `camel-aws-common`
- `camel-aws-config`
- `camel-aws-parameter-store`
- `camel-aws-parent`
- `camel-aws-secrets-manager`
- `camel-aws-security-hub`
- `camel-aws2-athena`
- `camel-aws2-comprehend`
- `camel-aws2-cw`
- `camel-aws2-ddb`
- `camel-aws2-ec2`
- `camel-aws2-ecs`
- `camel-aws2-eks`
- `camel-aws2-eventbridge`
- `camel-aws2-iam`
- `camel-aws2-kinesis`
- `camel-aws2-kms`
- `camel-aws2-lambda`
- `camel-aws2-mq`
- `camel-aws2-msk`
- `camel-aws2-polly`
- `camel-aws2-redshift`
- `camel-aws2-rekognition`
- `camel-aws2-s3`
- `camel-aws2-s3-vectors`
- `camel-aws2-ses`
- `camel-aws2-sns`
- `camel-aws2-sqs`
- `camel-aws2-step-functions`
- `camel-aws2-sts`
- `camel-aws2-textract`
- `camel-aws2-timestream`
- `camel-aws2-transcribe`
- `camel-aws2-translate`
- `camel-azure-common`
- `camel-azure-cosmosdb`
- `camel-azure-eventgrid`
- `camel-azure-eventhubs`
- `camel-azure-files`
- `camel-azure-functions`
- `camel-azure-key-vault`
- `camel-azure-parent`
- `camel-azure-schema-registry`
- `camel-azure-servicebus`
- `camel-azure-storage-blob`
- `camel-azure-storage-datalake`
- `camel-azure-storage-queue`
- `camel-barcode`
- `camel-base`
- `camel-base-engine`
- `camel-base64`
- `camel-bean`
- `camel-bean-validator`
- `camel-beanio`
- `camel-bindy`
- `camel-bonita`
- `camel-box`
- `camel-box-api`
- `camel-box-parent`
- `camel-braintree`
- `camel-browse`
- `camel-caffeine`
- `camel-camunda`
- `camel-cassandraql`
- `camel-catalog-common`
- `camel-cbor`
- `camel-chatscript`
- `camel-chunk`
- `camel-cli-connector`
- `camel-cli-debug`
- `camel-clickhouse`
- `camel-clickup`
- `camel-cloudevents`
- `camel-cluster`
- `camel-cm-sms`
- `camel-coap`
- `camel-cometd`
- `camel-console`
- `camel-consul`
- `camel-controlbus`
- `camel-core`
- `camel-core-all`
- `camel-core-engine`
- `camel-core-languages`
- `camel-core-model`
- `camel-core-processor`
- `camel-core-reifier`
- `camel-core-xml`
- `camel-couchbase`
- `camel-couchdb`
- `camel-cron`
- `camel-crypto`
- `camel-crypto-pgp`
- `camel-csv`
- `camel-cxf-common`
- `camel-cxf-parent`
- `camel-cxf-rest`
- `camel-cxf-soap`
- `camel-cxf-spring-common`
- `camel-cxf-spring-rest`
- `camel-cxf-spring-soap`
- `camel-cxf-spring-transport`
- `camel-cxf-transport`
- `camel-cyberark-vault`
- `camel-dapr`
- `camel-dataformat`
- `camel-dataset`
- `camel-datasonnet`
- `camel-dataweave`
- `camel-debezium-common`
- `camel-debezium-common-parent`
- `camel-debezium-db2`
- `camel-debezium-maven-plugin`
- `camel-debezium-mongodb`
- `camel-debezium-mysql`
- `camel-debezium-oracle`
- `camel-debezium-parent`
- `camel-debezium-postgres`
- `camel-debezium-sqlserver`
- `camel-debug`
- `camel-dfdl`
- `camel-dhis2`
- `camel-dhis2-api`
- `camel-dhis2-parent`
- `camel-diagram`
- `camel-direct`
- `camel-disruptor`
- `camel-djl`
- `camel-dns`
- `camel-docker`
- `camel-docling`
- `camel-drill`
- `camel-dropbox`
- `camel-dsl-modeline`
- `camel-dsl-support`
- `camel-duckdb`
- `camel-dynamic-router`
- `camel-ehcache`
- `camel-elasticsearch`
- `camel-elasticsearch-rest-client`
- `camel-event`
- `camel-exec`
- `camel-fastjson`
- `camel-fhir`
- `camel-fhir-api`
- `camel-fhir-parent`
- `camel-file`
- `camel-file-watch`
- `camel-flatpack`
- `camel-flink`
- `camel-flowable`
- `camel-fop`
- `camel-fory`
- `camel-freemarker`
- `camel-ftp`
- `camel-ftp-common`
- `camel-geocoder`
- `camel-git`
- `camel-github2`
- `camel-google-bigquery`
- `camel-google-calendar`
- `camel-google-common`
- `camel-google-drive`
- `camel-google-firestore`
- `camel-google-functions`
- `camel-google-mail`
- `camel-google-parent`
- `camel-google-pubsub`
- `camel-google-secret-manager`
- `camel-google-sheets`
- `camel-google-speech-to-text`
- `camel-google-storage`
- `camel-google-text-to-speech`
- `camel-google-vertexai`
- `camel-google-vision`
- `camel-graphql`
- `camel-grok`
- `camel-groovy`
- `camel-grpc`
- `camel-gson`
- `camel-hashicorp-vault`
- `camel-hazelcast`
- `camel-health`
- `camel-hivemq`
- `camel-hl7`
- `camel-http`
- `camel-http-base`
- `camel-http-common`
- `camel-huawei-parent`
- `camel-huaweicloud-common`
- `camel-huaweicloud-dms`
- `camel-huaweicloud-frs`
- `camel-huaweicloud-functiongraph`
- `camel-huaweicloud-iam`
- `camel-huaweicloud-imagerecognition`
- `camel-huaweicloud-obs`
- `camel-huaweicloud-smn`
- `camel-huggingface`
- `camel-ibm-cos`
- `camel-ibm-parent`
- `camel-ibm-secrets-manager`
- `camel-ibm-watson-discovery`
- `camel-ibm-watson-language`
- `camel-ibm-watson-speech-to-text`
- `camel-ibm-watson-text-to-speech`
- `camel-ibm-watsonx-ai`
- `camel-ibm-watsonx-data`
- `camel-ical`
- `camel-iggy`
- `camel-ignite`
- `camel-infinispan`
- `camel-infinispan-common`
- `camel-infinispan-embedded`
- `camel-infinispan-parent`
- `camel-influxdb`
- `camel-influxdb2`
- `camel-iso8583`
- `camel-jackson`
- `camel-jackson-avro`
- `camel-jackson-protobuf`
- `camel-jackson3`
- `camel-jackson3-avro`
- `camel-jackson3-protobuf`
- `camel-jackson3xml`
- `camel-jacksonxml`
- `camel-jactl`
- `camel-jandex`
- `camel-jasypt`
- `camel-java-io`
- `camel-java-joor-dsl`
- `camel-javascript`
- `camel-jaxb`
- `camel-jbang-console`
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-jcache`
- `camel-jcr`
- `camel-jdbc`
- `camel-jetty`
- `camel-jetty-common`
- `camel-jfr`
- `camel-jgroups`
- `camel-jgroups-raft`
- `camel-jira`
- `camel-jms`
- `camel-jmx`
- `camel-jolt`
- `camel-jooq`
- `camel-joor`
- `camel-jpa`
- `camel-jq`
- `camel-jsch`
- `camel-jslt`
- `camel-json-validator`
- `camel-jsonapi`
- `camel-jsonata`
- `camel-jsonb`
- `camel-jsonpath`
- `camel-jsoup`
- `camel-jt400`
- `camel-jta`
- `camel-jte`
- `camel-kafka`
- `camel-kamelet`
- `camel-kamelet-main-support`
- `camel-keycloak`
- `camel-knative`
- `camel-knative-api`
- `camel-knative-http`
- `camel-knative-parent`
- `camel-kserve`
- `camel-kubernetes`
- `camel-kudu`
- `camel-langchain4j-agent`
- `camel-langchain4j-agent-api`
- `camel-langchain4j-chat`
- `camel-langchain4j-core`
- `camel-langchain4j-embeddings`
- `camel-langchain4j-embeddingstore`
- `camel-langchain4j-embeddingstore-api`
- `camel-langchain4j-ingest`
- `camel-langchain4j-tokenizer`
- `camel-langchain4j-web-search`
- `camel-language`
- `camel-launcher-container`
- `camel-ldap`
- `camel-ldif`
- `camel-log`
- `camel-lra`
- `camel-lucene`
- `camel-lumberjack`
- `camel-lzf`
- `camel-mail`
- `camel-mail-microsoft-oauth`
- `camel-main`
- `camel-management`
- `camel-mapstruct`
- `camel-master`
- `camel-maven-plugin`
- `camel-mcp-server`
- `camel-mcp-server-api`
- `camel-mdc`
- `camel-metrics`
- `camel-micrometer`
- `camel-micrometer-observability`
- `camel-micrometer-prometheus`
- `camel-microprofile-config`
- `camel-microprofile-fault-tolerance`
- `camel-microprofile-health`
- `camel-microprofile-parent`
- `camel-milo`
- `camel-milvus`
- `camel-mina`
- `camel-mina-sftp`
- `camel-minio`
- `camel-mllp`
- `camel-mock`
- `camel-mongodb`
- `camel-mongodb-gridfs`
- `camel-mustache`
- `camel-mvel`
- `camel-mybatis`
- `camel-nats`
- `camel-neo4j`
- `camel-netty`
- `camel-netty-http`
- `camel-oaipmh`
- `camel-oauth`
- `camel-observability-services`
- `camel-observation`
- `camel-ocsf`
- `camel-ognl`
- `camel-olingo2`
- `camel-olingo2-api`
- `camel-olingo2-parent`
- `camel-olingo4`
- `camel-olingo4-api`
- `camel-olingo4-parent`
- `camel-once`
- `camel-opa`
- `camel-openai`
- `camel-openapi-java`
- `camel-openapi-rest-dsl-generator`
- `camel-openapi-validator`
- `camel-opensearch`
- `camel-openstack`
- `camel-opentelemetry`
- `camel-opentelemetry-metrics`
- `camel-opentelemetry2`
- `camel-optaplanner`
- `camel-paho`
- `camel-paho-mqtt5`
- `camel-parquet-avro`
- `camel-pdf`
- `camel-pg-replication-slot`
- `camel-pgevent`
- `camel-pgvector`
- `camel-pinecone`
- `camel-platform-http`
- `camel-platform-http-jolokia`
- `camel-platform-http-main`
- `camel-platform-http-vertx`
- `camel-plc4x`
- `camel-pqc`
- `camel-printer`
- `camel-protobuf`
- `camel-pubnub`
- `camel-pulsar`
- `camel-python`
- `camel-python3`
- `camel-qdrant`
- `camel-quartz`
- `camel-quickfix`
- `camel-quickjs`
- `camel-reactive-streams`
- `camel-reactor`
- `camel-redis`
- `camel-ref`
- `camel-resilience4j`
- `camel-resilience4j-micrometer`
- `camel-resourceresolver-github`
- `camel-rest`
- `camel-rest-openapi`
- `camel-rest-postman`
- `camel-restdsl-openapi-plugin`
- `camel-robotframework`
- `camel-rocketmq`
- `camel-rss`
- `camel-rxjava`
- `camel-saga`
- `camel-salesforce`
- `camel-salesforce-codegen`
- `camel-salesforce-maven-plugin`
- `camel-salesforce-parent`
- `camel-sap-netweaver`
- `camel-saxon`
- `camel-scheduler`
- `camel-schematron`
- `camel-seda`
- `camel-servicenow`
- `camel-servicenow-maven-plugin`
- `camel-servicenow-parent`
- `camel-servlet`
- `camel-shell`
- `camel-shiro`
- `camel-sjms`
- `camel-sjms2`
- `camel-slack`
- `camel-smb`
- `camel-smooks`
- `camel-smpp`
- `camel-snakeyaml`
- `camel-snmp`
- `camel-soap`
- `camel-solr`
- `camel-spiffe`
- `camel-splunk-hec`
- `camel-spring`
- `camel-spring-ai-chat`
- `camel-spring-ai-embeddings`
- `camel-spring-ai-image`
- `camel-spring-ai-parent`
- `camel-spring-ai-vector-store`
- `camel-spring-batch`
- `camel-spring-cloud-config`
- `camel-spring-jdbc`
- `camel-spring-ldap`
- `camel-spring-main`
- `camel-spring-parent`
- `camel-spring-rabbitmq`
- `camel-spring-redis`
- `camel-spring-security`
- `camel-spring-ws`
- `camel-spring-xml`
- `camel-sql`
- `camel-ssh`
- `camel-state-store`
- `camel-state-store-parent`
- `camel-stax`
- `camel-stitch`
- `camel-stream`
- `camel-streamcaching-test`
- `camel-stringtemplate`
- `camel-stripe`
- `camel-stub`
- `camel-support`
- `camel-swift`
- `camel-syslog`
- `camel-tahu`
- `camel-tarfile`
- `camel-telegram`
- `camel-telemetry`
- `camel-telemetry-dev`
- `camel-tensorflow-serving`
- `camel-test-infra-all`
- `camel-test-infra-artemis`
- `camel-test-infra-cli`
- `camel-test-infra-core`
- `camel-test-infra-smb`
- `camel-test-junit5`
- `camel-test-junit6`
- `camel-test-main-junit5`
- `camel-test-main-junit6`
- `camel-test-parent`
- `camel-test-spring-junit5`
- `camel-test-spring-junit6`
- `camel-thrift`
- `camel-thymeleaf`
- `camel-tika`
- `camel-timer`
- `camel-tooling-maven`
- `camel-toon`
- `camel-tracing`
- `camel-twilio`
- `camel-twitter`
- `camel-ubl`
- `camel-undertow`
- `camel-undertow-spring-security`
- `camel-univocity-parsers`
- `camel-validator`
- `camel-velocity`
- `camel-vertx`
- `camel-vertx-common`
- `camel-vertx-http`
- `camel-vertx-parent`
- `camel-vertx-websocket`
- `camel-wal`
- `camel-wasm`
- `camel-weather`
- `camel-weaviate`
- `camel-web3j`
- `camel-webhook`
- `camel-whatsapp`
- `camel-wordpress`
- `camel-workday`
- `camel-xchange`
- `camel-xj`
- `camel-xml-io`
- `camel-xml-io-dsl`
- `camel-xml-jaxb`
- `camel-xml-jaxb-dsl`
- `camel-xml-jaxb-dsl-test-definition`
- `camel-xml-jaxb-dsl-test-spring`
- `camel-xml-jaxp`
- `camel-xmlsecurity`
- `camel-xmpp`
- `camel-xpath`
- `camel-xslt`
- `camel-xslt-saxon`
- `camel-yaml-dsl-common`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
- `camel-yaml-io`
- `camel-zendesk`
- `camel-zip-deflater`
- `camel-zipfile`
- `camel-zookeeper`
- `camel-zookeeper-master`
- `components`
</details>
<details><summary>Modules with tests skipped (27)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>Build reactor — dependencies compiled but only changed modules were tested (3 modules, 35.2s total)</summary>
**Total reactor time:** 35.2s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: Support | 17.6s | SUCCESS |
| Camel :: Kamelet | 13.1s | SUCCESS |
| Camel :: Base Engine | 4.5s | SUCCESS |
**Top 20 slowest modules:**
- `Camel :: Support` (17.6s)
- `Camel :: Kamelet` (13.1s)
- `Camel :: Base Engine` (4.5s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/34952818611)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710105874
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709635398
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710202841
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709782643
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5677911324
<!-- camel-backport-bot -->
### 🔄 Backport Bot
This bugfix targets `main` and may need porting to:
- `camel-4.22.x`
Labels `port/<branch>` have been added. Remove a label to opt out of porting to that branch.
Port PRs will be created automatically when this PR is merged. Comment `/port` to create them now.
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710644110
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710995547
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710592561
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710918416
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710153377
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711087540
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709828370
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711204853
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710277431
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711264907
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711379233
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710023391
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711145765
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709881298
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711322843
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711419472
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #26456:
URL: https://github.com/apache/camel/pull/26456#discussion_r4025400666
##########
components/camel-kamelet/src/test/java/org/apache/camel/component/kamelet/KameletToDUrlEncodingTest.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.kamelet;
+
+import org.apache.camel.RoutesBuilder;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.junit6.CamelTestSupport;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Verifies that kamelet parameters containing URL-special characters are preserved intact when the kamelet is invoked
+ * via {@code toD}, matching the behaviour of the static {@code to} DSL (CAMEL-24747).
+ *
+ * <p>
+ * Prior to the fix, {@code SendDynamicProcessor.prepareRecipient()} created a
+ * {@link org.apache.camel.support.NormalizedUri} whose normalized (URL-encoded) form was then passed to
+ * {@code doGetEndpoint} as if it were the raw URI. Components that declare {@code useRawUri()=true} (such as
+ * {@link KameletComponent}) therefore received the encoded form ({@code http%3A%2F%2F…}) instead of the original value.
+ */
+class KameletToDUrlEncodingTest extends CamelTestSupport {
+
+ /**
+ * A parameter value that contains URL-special characters: {@code %}, {@code +}, {@code ?} and {@code =}. These must
+ * survive the round-trip through {@code toD} unmodified.
+ */
+ private static final String PARAM_WITH_SPECIAL_CHARS = "http://example.com?key=abc%+def";
+
+ @Test
+ void toDPreservesSpecialCharsLikeTo() {
+ // Use toD with a literal URI containing URL-special characters in a parameter value.
+ // The result should be identical to what the static `to` DSL produces.
+ String resultTo = template.requestBody("direct:via-to", (Object) null, String.class);
+ String resultToD = template.requestBody("direct:via-tod", (Object) null, String.class);
+
+ assertThat(resultTo)
+ .as("to: parameter value must not be URL-encoded")
+ .isEqualTo(PARAM_WITH_SPECIAL_CHARS);
+
+ assertThat(resultToD)
+ .as("toD: parameter value must equal what to produces (CAMEL-24747)")
+ .isEqualTo(resultTo);
+ }
+
+ /**
+ * Negative test: components that do NOT declare {@code useRawUri()=true} continue to receive the normalised URI via
+ * {@code toD}, proving that the fix is surgically scoped to {@code useRawUri} components only.
+ */
+ @Test
+ void toDNonRawUriComponentIsUnaffected() throws Exception {
+ MockEndpoint mock = getMockEndpoint("mock:result");
+ mock.expectedMessageCount(1);
+ mock.expectedBodiesReceived("hello");
+
+ template.sendBody("direct:via-tod-mock", "hello");
+
+ MockEndpoint.assertIsSatisfied(context);
+ }
+
+ @Override
+ protected RoutesBuilder createRouteBuilder() {
+ return new RouteBuilder() {
+ @Override
+ public void configure() {
+ routeTemplate("echo-uri")
+ .templateParameter("uri")
+ .from("kamelet:source")
+ .setBody().constant("{{uri}}");
+
+ // static `to` — baseline: known to pass the raw URI correctly
+ from("direct:via-to")
+ .to("kamelet:echo-uri?uri=" + PARAM_WITH_SPECIAL_CHARS);
+
+ // dynamic `toD` — was broken before the fix (CAMEL-24747)
+ from("direct:via-tod")
+ .toD("kamelet:echo-uri?uri=" + PARAM_WITH_SPECIAL_CHARS);
Review Comment:
This test passes without the core fix. `from("direct:via-to").to("kamelet:echo-uri?uri=…")` resolves its endpoint at context start and registers it under the normalized key; at runtime `SendDynamicProcessor` calls `getExistingEndpoint()` → `hasEndpoint(NormalizedUri)` first (`SendDynamicProcessor.java:191`), gets a cache hit on that same key, and reuses the endpoint `to` created with the raw URI — `doGetEndpoint` is never reached for this route.
Verified locally: with `core/` reverted to the merge-base (jar has no `getRawUri`), this class is 2/2 green. The same value in a `toD`-only route fails with `but was: "http%3A%2F%2Fexample.com%3Fkey%3Dabc%25+def"` and passes with your fix.
Suggested change (three spots, so no suggestion block): add a second constant with a distinct value, e.g.
```java
private static final String PARAM_WITH_SPECIAL_CHARS_TOD = "http://example.com?key=xyz%+def";
```
use it here — `.toD("kamelet:echo-uri?uri=" + PARAM_WITH_SPECIAL_CHARS_TOD)` — and assert `resultToD` against `PARAM_WITH_SPECIAL_CHARS_TOD` instead of `isEqualTo(resultTo)`. The `to` route can stay as the baseline showing the static path is unaffected.
(`toDNonRawUriComponentIsUnaffected` also passes either way — fine as a smoke test, but it does not demonstrate the scoping its Javadoc describes.)
##########
core/camel-support/src/main/java/org/apache/camel/support/NormalizedUri.java:
##########
@@ -41,12 +47,23 @@ private NormalizedUri(String value) {
*/
public static NormalizedUri newNormalizedUri(String uri, boolean normalized) {
if (normalized) {
- return new NormalizedUri(uri);
+ return new NormalizedUri(uri, uri);
Review Comment:
Nit: on this path the caller says the URI is already normalized, so the raw form is simply unknown — but `getRawUri()` will return the normalized string, contradicting its Javadoc ("the raw (un-normalized) URI"). Behaviour is identical either way since `doGetEndpoint` already falls back with `explicitRawUri != null ? explicitRawUri : uri`, so storing `null` here (and noting in the getter Javadoc that it may be `null` when the raw form is not known) keeps the contract honest.
```suggestion
return new NormalizedUri(uri, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5677927377
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709949165
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5711440880
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Cherry-pick conflict in: docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710698059
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710537397
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710329553
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709694039
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709737558
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5771875510
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Cherry-pick conflict in: docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #26456:
URL: https://github.com/apache/camel/pull/26456#discussion_r4025428854
##########
components/camel-kamelet/src/test/java/org/apache/camel/component/kamelet/KameletToDUrlEncodingTest.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.kamelet;
+
+import org.apache.camel.RoutesBuilder;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.junit6.CamelTestSupport;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/**
+ * Verifies that kamelet parameters containing URL-special characters are preserved intact when the kamelet is invoked
+ * via {@code toD}, matching the behaviour of the static {@code to} DSL (CAMEL-24747).
+ *
+ * <p>
+ * Prior to the fix, {@code SendDynamicProcessor.prepareRecipient()} created a
+ * {@link org.apache.camel.support.NormalizedUri} whose normalized (URL-encoded) form was then passed to
+ * {@code doGetEndpoint} as if it were the raw URI. Components that declare {@code useRawUri()=true} (such as
+ * {@link KameletComponent}) therefore received the encoded form ({@code http%3A%2F%2F…}) instead of the original value.
+ */
+class KameletToDUrlEncodingTest extends CamelTestSupport {
+
+ /**
+ * A parameter value that contains URL-special characters: {@code %}, {@code +}, {@code ?} and {@code =}. These must
+ * survive the round-trip through {@code toD} unmodified.
+ */
+ private static final String PARAM_WITH_SPECIAL_CHARS = "http://example.com?key=abc%+def";
+
+ @Test
+ void toDPreservesSpecialCharsLikeTo() {
+ // Use toD with a literal URI containing URL-special characters in a parameter value.
+ // The result should be identical to what the static `to` DSL produces.
+ String resultTo = template.requestBody("direct:via-to", (Object) null, String.class);
+ String resultToD = template.requestBody("direct:via-tod", (Object) null, String.class);
+
+ assertThat(resultTo)
+ .as("to: parameter value must not be URL-encoded")
+ .isEqualTo(PARAM_WITH_SPECIAL_CHARS);
+
+ assertThat(resultToD)
+ .as("toD: parameter value must equal what to produces (CAMEL-24747)")
+ .isEqualTo(resultTo);
+ }
+
+ /**
+ * Negative test: components that do NOT declare {@code useRawUri()=true} continue to receive the normalised URI via
+ * {@code toD}, proving that the fix is surgically scoped to {@code useRawUri} components only.
+ */
+ @Test
+ void toDNonRawUriComponentIsUnaffected() throws Exception {
+ MockEndpoint mock = getMockEndpoint("mock:result");
+ mock.expectedMessageCount(1);
+ mock.expectedBodiesReceived("hello");
+
+ template.sendBody("direct:via-tod-mock", "hello");
+
+ MockEndpoint.assertIsSatisfied(context);
+ }
+
+ @Override
+ protected RoutesBuilder createRouteBuilder() {
+ return new RouteBuilder() {
+ @Override
+ public void configure() {
+ routeTemplate("echo-uri")
+ .templateParameter("uri")
+ .from("kamelet:source")
+ .setBody().constant("{{uri}}");
+
+ // static `to` — baseline: known to pass the raw URI correctly
+ from("direct:via-to")
+ .to("kamelet:echo-uri?uri=" + PARAM_WITH_SPECIAL_CHARS);
+
+ // dynamic `toD` — was broken before the fix (CAMEL-24747)
+ from("direct:via-tod")
+ .toD("kamelet:echo-uri?uri=" + PARAM_WITH_SPECIAL_CHARS);
Review Comment:
Fixed in 825d23f1b745: added `PARAM_WITH_SPECIAL_CHARS_TOD` (distinct value `xyz%+def`) for the `toD` route, and assert it directly against the constant rather than against `resultTo`. The `to` route keeps `abc%+def` as the unaffected baseline.
##########
core/camel-support/src/main/java/org/apache/camel/support/NormalizedUri.java:
##########
@@ -41,12 +47,23 @@ private NormalizedUri(String value) {
*/
public static NormalizedUri newNormalizedUri(String uri, boolean normalized) {
if (normalized) {
- return new NormalizedUri(uri);
+ return new NormalizedUri(uri, uri);
Review Comment:
Fixed in 825d23f1b745: `newNormalizedUri(uri, normalized=true)` now stores `null` for `rawUri`, and the Javadoc documents that the getter may return `null` when the raw form is unknown. `doGetEndpoint` already handles `null` via the `explicitRawUri != null ? explicitRawUri : uri` fallback, so behaviour is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5709568904
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Cherry-pick conflict in: docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_23.adoc
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26456:
URL: https://github.com/apache/camel/pull/26456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710378965
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710432145
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24747: Preserve raw URI for useRawUri() components when using toD [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on PR #26456:
URL: https://github.com/apache/camel/pull/26456#issuecomment-5710484613
<!-- camel-backport-bot -->
### 🔄 Backport Bot
**Conflicts (🤖 agent dispatched to resolve):**
- ⚠️ `camel-4.22.x` — Command failed: git checkout -b backport/26456-to-camel-4.22.x
fatal: a branch named 'backport/26456-to-camel-4.22.x' already exists
ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org