You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/29 15:42:06 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #2216: FINERACT-1557-fix
fynmanoj opened a new pull request #2216:
URL: https://github.com/apache/fineract/pull/2216
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic closed pull request #2216: FINERACT-1557-fix
Posted by GitBox <gi...@apache.org>.
vidakovic closed pull request #2216:
URL: https://github.com/apache/fineract/pull/2216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2216: FINERACT-1557-fix
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2216:
URL: https://github.com/apache/fineract/pull/2216#issuecomment-1083294487
FYI: Victor is taking over to investigate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2216: FINERACT-1557-fix
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2216:
URL: https://github.com/apache/fineract/pull/2216#issuecomment-1083332172
Closing this one to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2216: FINERACT-1557-fix
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2216:
URL: https://github.com/apache/fineract/pull/2216#issuecomment-1082424344
@fynmanoj the build is failing since this commit https://github.com/apache/fineract/commit/d5c611564f7b8c877136f3b3aca647bf7de15fe0 ... i. e. there is some correlation with EclipseLink. I have disabled the failing tests for now in my PR until we can further analyze this. I will create a Jira issue and add the 3 tests so that we solve this before the next release.
FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #2216: FINERACT-1557-fix
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #2216:
URL: https://github.com/apache/fineract/pull/2216#issuecomment-1082867949
@vidakovic This PR contains fix for an issue found in the stacktrace, so we may still need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org