You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2023/01/19 04:21:16 UTC
[GitHub] [sedona] jiayuasu commented on a diff in pull request #748: [SEDONA-233] Incorrect results for several joins in a single stage
jiayuasu commented on code in PR #748:
URL: https://github.com/apache/sedona/pull/748#discussion_r1080791389
##########
core/src/test/java/org/apache/sedona/core/spatialOperator/JoinQueryDeduplicationTest.java:
##########
@@ -0,0 +1,75 @@
+/*
Review Comment:
Could you please add another test in Sedona Spark SQL to verify that this bug is eliminated?
##########
core/src/main/java/org/apache/sedona/core/joinJudgement/DuplicatesFilter.java:
##########
@@ -0,0 +1,48 @@
+package org.apache.sedona.core.joinJudgement;
+
Review Comment:
Please add Apache License header here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org