You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/03/14 15:55:10 UTC

(superset) branch fix_docker_master_oncemore created (now 63c888ff59)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a change to branch fix_docker_master_oncemore
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 63c888ff59 fix: another attempt at fixing docker master builds

This branch includes the following new commits:

     new 63c888ff59 fix: another attempt at fixing docker master builds

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(superset) 01/01: fix: another attempt at fixing docker master builds

Posted by ma...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch fix_docker_master_oncemore
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 63c888ff593610ecc8bf654cb548f1c4642adb3e
Author: Maxime Beauchemin <ma...@gmail.com>
AuthorDate: Thu Mar 14 08:54:05 2024 -0700

    fix: another attempt at fixing docker master builds
    
    Somehow forgot to docker login when I migrated the script over.
    Hoping this does the trick after multiple failed attempts at
    fixing this.
---
 .github/workflows/docker.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index ef81b99581..bedf12a957 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -60,6 +60,9 @@ jobs:
           DOCKERHUB_USER: ${{ secrets.DOCKERHUB_USER }}
           DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
         run: |
+          if [ -n "$DOCKERHUB_TOKEN" ]; then
+            docker login
+          fi
           # Single platform builds in pull_request context to speed things up
           if [ "${{ github.event_name }}" = "push" ]; then
             PLATFORM_ARG="--platform linux/arm64 --platform linux/amd64"