You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/05/03 04:15:49 UTC

[PR] test(amber): add unit test coverage for AmberFIFOChannel and WorkerPort [texera]

aglinxinyuan opened a new pull request, #4831:
URL: https://github.com/apache/texera/pull/4831

   ### What changes were proposed in this PR?
   
   Add two specs covering the messaging-layer pure-logic primitives.
   
   `AmberFIFOChannelSpec` (per-channel exactly-once FIFO ordering):
   - Construction defaults (empty queue, sequence 0, zero credit, enabled)
   - `acceptMessage` in-order delivery advances `currentSeq` and credit
   - Out-of-order seq stashes; subsequent in-order seq drains the stash in FIFO order
   - Duplicate-below-current is silently dropped
   - Duplicate stash does not double-count the stash size
   - `take` decrements `getQueuedCredit` by the dequeued message size
   - `enable` / `isEnabled` toggle
   - `getPortId` throws when no port id is set; returns the most recently configured port id
   
   `WorkerPortSpec` (WorkerPort case-class shape):
   - Default empty channel set / not-completed
   - Channel set wiring at construction and post-construction append
   - `completed` mutable flip
   - Case-class equality across distinct instances
   
   `WorkerTimerService` is intentionally skipped because it is a thin wrapper around `AkkaActorService.sendToSelfWithFixedDelay` and would require a full Pekko harness for low-value scheduling assertions.
   
   ### Any related issues, documentation, discussions?
   
   Closes #4830
   
   ### How was this PR tested?
   
   `sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.messaginglayer.AmberFIFOChannelSpec org.apache.texera.amber.engine.architecture.messaginglayer.WorkerPortSpec"` — 15/15 tests pass.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.7)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): add unit test coverage for AmberFIFOChannel and WorkerPort [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #4831:
URL: https://github.com/apache/texera/pull/4831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(amber): add unit test coverage for AmberFIFOChannel and WorkerPort [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4831:
URL: https://github.com/apache/texera/pull/4831#issuecomment-4365374275

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/4831?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 42.84%. Comparing base ([`945849c`](https://app.codecov.io/gh/apache/texera/commit/945849ce4f7ba77091e930b53b0b35440e33b994?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4cf7764`](https://app.codecov.io/gh/apache/texera/commit/4cf77641f7b8dd369f7fedc37c7a2134cb39a47a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #4831   +/-   ##
   =========================================
     Coverage     42.84%   42.84%           
     Complexity     2027     2027           
   =========================================
     Files           957      957           
     Lines         34077    34077           
     Branches       3753     3753           
   =========================================
     Hits          14600    14600           
     Misses        18693    18693           
     Partials        784      784           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/4831/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/texera/pull/4831/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.15% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/4831?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org