You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Tom Bentley (Jira)" <ji...@apache.org> on 2020/12/11 07:12:00 UTC

[jira] [Assigned] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

     [ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom Bentley reassigned KAFKA-10841:
-----------------------------------

    Assignee: GeordieMai

> LogReadResult should be able to converted to FetchPartitionData 
> ----------------------------------------------------------------
>
>                 Key: KAFKA-10841
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10841
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: GeordieMai
>            Priority: Minor
>              Labels: newbie
>
> There are duplicate code which try to convert LogReadResult to FetchPartitionData. It seems to me the duplicate code can be eliminated by moving the conversion to LogReadResult.
> occurrence 1: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1076
> occurrence 2:
> https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/DelayedFetch.scala#L189
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)