You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/16 00:55:55 UTC
Review Request 13609: Fixed slave to properly handle queued tasks when
during recovery and KillTask().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13609/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-646
https://issues.apache.org/jira/browse/MESOS-646
Repository: mesos-git
Description
-------
Fixed 2 things:
--> Properly handling queued tasks that were not launched.
--> Properly killing executor when it hasn't registered yet.
Diffs
-----
src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
Diff: https://reviews.apache.org/r/13609/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13609: Fixed slave to properly handle queued tasks when
during recovery and KillTask().
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 16, 2013, 12:47 a.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 1719
> > <https://reviews.apache.org/r/13609/diff/1/?file=341595#file341595line1719>
> >
> > I don't have a great suggestion for a more descriptive message, but how about:
> >
> > "Task lost during slave recovery (due to the slave restarting prior to the task reaching the executor)."
> >
> > Thoughts?
"Task launched during slave restart."?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13609/#review25224
-----------------------------------------------------------
On Aug. 15, 2013, 10:55 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13609/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-646
> https://issues.apache.org/jira/browse/MESOS-646
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed 2 things:
>
> --> Properly handling queued tasks that were not launched.
> --> Properly killing executor when it hasn't registered yet.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
> src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
>
> Diff: https://reviews.apache.org/r/13609/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13609: Fixed slave to properly handle queued tasks when
during recovery and KillTask().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13609/#review25224
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/13609/#comment49522>
s/that//?
src/slave/slave.cpp
<https://reviews.apache.org/r/13609/#comment49523>
I don't have a great suggestion for a more descriptive message, but how about:
"Task lost during slave recovery (due to the slave restarting prior to the task reaching the executor)."
Thoughts?
- Ben Mahler
On Aug. 15, 2013, 10:55 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13609/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-646
> https://issues.apache.org/jira/browse/MESOS-646
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed 2 things:
>
> --> Properly handling queued tasks that were not launched.
> --> Properly killing executor when it hasn't registered yet.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
> src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
>
> Diff: https://reviews.apache.org/r/13609/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13609: Fixed slave to properly handle queued tasks during
recovery and KillTask().
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13609/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 2:32 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Summary (updated)
-----------------
Fixed slave to properly handle queued tasks during recovery and KillTask().
Bugs: MESOS-646
https://issues.apache.org/jira/browse/MESOS-646
Repository: mesos-git
Description
-------
Fixed 2 things:
--> Properly handling queued tasks that were not launched.
--> Properly killing executor when it hasn't registered yet.
Diffs (updated)
-----
src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce
src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2
Diff: https://reviews.apache.org/r/13609/diff/
Testing
-------
make check
Thanks,
Vinod Kone