You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2017/02/01 11:01:25 UTC
[GitHub] jena pull request #213: JENA-1285: One token type for strings
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/213
JENA-1285: One token type for strings
Having 4 separate string token types means that all four cases have to be considered, yet the more common case is that a string has been seen. Only sometimes does the exact form of the string matter.
This PR changes Jena to have one token type for STRING and separately record the string type seen for when it is needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena token
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit 781895ce64e062c7f2268a78189a777c39b92844
Author: Andy Seaborne <an...@apache.org>
Date: 2017-01-27T13:31:59Z
Improve bulk operations depending on relative sizes of graphs
commit 01419943d908676152c43a66bda16cb90cba3a46
Author: Andy Seaborne <an...@apache.org>
Date: 2017-01-28T12:13:16Z
Extra tests for bulk addInto/deleteFrom.
commit 0e2fad4f2e7e4237d27847839fa3a7b8eb1941d8
Author: Andy Seaborne <an...@apache.org>
Date: 2017-01-31T21:20:30Z
One kind of tokenized string, with string type recorded separately.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #213: JENA-1285: One token type for strings
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena issue #213: JENA-1285: One token type for strings
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/213
+1: this is clearer. But that's coming from someone w/o much familiarity with this part of the code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request #213: JENA-1285: One token type for strings
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/213#discussion_r98915106
--- Diff: jena-arq/src/main/java/org/apache/jena/riot/tokens/StringType.java ---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.riot.tokens;
+
+/** Seen form of a {@link TokenType#STRING} */
+public enum StringType { STRING1, STRING2, LONG_STRING1, LONG_STRING2 }
--- End diff --
It would be nice to have a quick comment explaining what the actual difference amongst these guys is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---