[GitHub] [spark] ueshin commented on a diff in pull request #40024: [SPARK-42426][CONNECT] Fix DataFrameWriter.insertInto to call the corresponding method instead of saveAsTable

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #40024:
URL: https://github.com/apache/spark/pull/40024#discussion_r1106665677


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -91,6 +91,16 @@ message WriteOperation {
   // (Optional) A list of configuration options.
   map<string, string> options = 9;
 
+  message SaveTable {
+    string table_name = 1;
+    TableSaveMethod save_method = 2;
+
+    enum TableSaveMethod {
+      SAVE_AS_TABLE = 0;
+      INSERT_INTO = 1;

Review Comment:
   I'm afraid I don't think it's a good idea. The method and mode are orthogonal concepts. Spark Connect should let Spark decide how it should behave with the options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org