You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/11/26 04:28:50 UTC
[GitHub] [groovy] paulk-asert opened a new pull request #1434: GROOVY-9826: Better propagation of InterruptedException
paulk-asert opened a new pull request #1434:
URL: https://github.com/apache/groovy/pull/1434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on pull request #1434:
URL: https://github.com/apache/groovy/pull/1434#issuecomment-734530876
Proposed PR merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] JLLeitschuh commented on a change in pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
JLLeitschuh commented on a change in pull request #1434:
URL: https://github.com/apache/groovy/pull/1434#discussion_r617941118
##########
File path: subprojects/groovy-jmx/src/test/java/groovy/jmx/builder/JmxConnectorHelper.java
##########
@@ -45,7 +45,7 @@ public static Map createRmiRegistry(int initPort) {
port = port + 1;
System.out.println("JmxBuilder - *** FAILED *** to create RMI Registry - Will Retry on port [" + port + "].");
try {
- Thread.currentThread().sleep(500);
+ Thread.sleep(500);
} catch (InterruptedException e) {
throw new RuntimeException(e);
Review comment:
@paulk-asert 👋 was this ever resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] JLLeitschuh commented on a change in pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
JLLeitschuh commented on a change in pull request #1434:
URL: https://github.com/apache/groovy/pull/1434#discussion_r532651111
##########
File path: subprojects/groovy-jmx/src/test/java/groovy/jmx/builder/JmxConnectorHelper.java
##########
@@ -45,7 +45,7 @@ public static Map createRmiRegistry(int initPort) {
port = port + 1;
System.out.println("JmxBuilder - *** FAILED *** to create RMI Registry - Will Retry on port [" + port + "].");
try {
- Thread.currentThread().sleep(500);
+ Thread.sleep(500);
} catch (InterruptedException e) {
throw new RuntimeException(e);
Review comment:
You still need to reset the interrupt flag here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit merged pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1434:
URL: https://github.com/apache/groovy/pull/1434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a change in pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on a change in pull request #1434:
URL: https://github.com/apache/groovy/pull/1434#discussion_r635261758
##########
File path: subprojects/groovy-jmx/src/test/java/groovy/jmx/builder/JmxConnectorHelper.java
##########
@@ -45,7 +45,7 @@ public static Map createRmiRegistry(int initPort) {
port = port + 1;
System.out.println("JmxBuilder - *** FAILED *** to create RMI Registry - Will Retry on port [" + port + "].");
try {
- Thread.currentThread().sleep(500);
+ Thread.sleep(500);
} catch (InterruptedException e) {
throw new RuntimeException(e);
Review comment:
I created these:
https://issues.apache.org/jira/browse/GROOVY-10097
https://github.com/apache/groovy/pull/1579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1434: GROOVY-9826: Better propagation of InterruptedException
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1434:
URL: https://github.com/apache/groovy/pull/1434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org