[jira] [Commented] (MESOS-1426) Update apply-review.sh and post-reviews.py to include JIRA tickets in the commit message.

["Deshi Xiao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217684#comment-15217684 ] 

Deshi Xiao commented on MESOS-1426:
-----------------------------------

[~bmahler]  Does it valid from now?

> Update apply-review.sh and post-reviews.py to include JIRA tickets in the commit message.
> -----------------------------------------------------------------------------------------
>
>                 Key: MESOS-1426
>                 URL: https://issues.apache.org/jira/browse/MESOS-1426
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Benjamin Mahler
>            Priority: Critical
>              Labels: newbie
>
> It appears that we should convert apply-review.sh to a python script in order to accomplish this as the use of jsonurl.py does not work well with json lists:
> {noformat}
> ./support/jsonurl.py https://reviews.apache.org/api/review-requests/21968/ review_request summary
> Fix issue #878 Slave should not register with the master when in TERMINATING.
> {noformat}
>  vs.
> {noformat}
> ./support/jsonurl.py https://reviews.apache.org/api/review-requests/21968/ review_request bugs_closed
> [u'MESOS-878']
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)