You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/13 09:01:20 UTC

[GitHub] [cloudstack] soreana opened a new pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

soreana opened a new pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   ### Description
   
   As a cloudstack team, we want to show sorted NICs in the Nic tab of the instance and API calls. To achieve this goal, cloudstack should put the deviceid in userVmResponse. This is the minor PR to add this feature.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   
   ### Screenshots (if appropriate):
   ![Screenshot 2021-03-08 at 04 27 21](https://user-images.githubusercontent.com/9499410/110270779-e0ff1e00-7fc6-11eb-9cdb-8cf015818102.png)
   
   
   ### How Has This Been Tested?
   
   I deployed the following instance in my test environment with three networks, as you can see they are sorted in NIC tab.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-888511612


   <b>Trillian test result (tid-1390)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35235 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1390-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 88 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_site2site_vpn_multiple_options | `Failure` | 470.37 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837969624


   @rhtyd are we still considdering this for 4.15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-878906149


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-877170913


   Hi @soreana can you please fix the conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797464622


   +1 I didn't look at code changes, if it involved db changes.
   
   On Fri, 12 Mar, 2021, 4:27 pm Wei Zhou, ***@***.***> wrote:
   
   > @rhtyd <https://github.com/rhtyd> (cc @soreana
   > <https://github.com/soreana> ) though it is a minor change it does
   > include AI and DB changes, so I'd say leave it for 4.16 (that is not a
   > definite 👎 at all, just a expression of our merge principles and
   > principles are there to be broken with)
   >
   > @DaanHoogland <https://github.com/DaanHoogland> let's merge it to 4.16.
   > as far as I know, 4.15 accepts only bug fixes and security fixes.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/cloudstack/pull/4768#issuecomment-797413805>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAAXHYZO6TTUCMP73ZM5SP3TDHXRPANCNFSM4YY5UL6Q>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882916375


   <b>Trillian test result (tid-1310)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 67193 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1310-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 78 look OK, 11 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 1197.35 | test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.11 | test_service_offerings.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 283.18 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 463.77 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-880467653


   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-887184517


   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-887169402


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] soreana edited a comment on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
soreana edited a comment on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-877175949


   I fixed the conflict.
   @weizhouapache @nvazquez @rhtyd Sorry for the late response. As I was away for couple of weeks, I completely forgot about this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837067974


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-866914150


   Hi @soreana can you please fix the conflict?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] soreana commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
soreana commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-877175949


   I fixed the conflict.
   @weizhouapache @nvazquez @rhtyd Sorry for the late response guys. As I was away for couple of weeks, I completely forgot about this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-888088521


   <b>Trillian test result (tid-1383)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 98854 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1383-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
   Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 66 look OK, 23 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_iso_with_checksum_sha1 | `Error` | 66.38 | test_iso.py
   test_02_create_iso_with_checksum_sha256 | `Error` | 66.38 | test_iso.py
   test_03_create_iso_with_checksum_md5 | `Error` | 66.40 | test_iso.py
   test_04_create_iso_with_no_checksum | `Error` | 66.35 | test_iso.py
   ContextSuite context=TestISO>:setup | `Error` | 1562.78 | test_iso.py
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
   test_DeleteDomain | `Error` | 4.00 | test_accounts.py
   test_forceDeleteDomain | `Failure` | 4.10 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 5.03 | test_accounts.py
   ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1516.59 | test_domain_service_offerings.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
   ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
   test_list_clusters_metrics | `Error` | 1511.88 | test_metrics_api.py
   test_list_vms_metrics | `Error` | 0.18 | test_metrics_api.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
   ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
   ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
   ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
   ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
   ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
   test_delete_account | `Error` | 1511.35 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 1.11 | test_network.py
   test_deploy_vm_l2network | `Error` | 1.10 | test_network.py
   test_l2network_restart | `Error` | 2.16 | test_network.py
   ContextSuite context=TestPortForwarding>:setup | `Error` | 3.31 | test_network.py
   ContextSuite context=TestPublicIP>:setup | `Error` | 1.02 | test_network.py
   test_reboot_router | `Failure` | 0.04 | test_network.py
   test_releaseIP | `Error` | 0.54 | test_network.py
   ContextSuite context=TestRouterRules>:setup | `Error` | 0.58 | test_network.py
   ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
   test_01_add_delete_kubernetes_supported_version | `Error` | 120.86 | test_kubernetes_supported_versions.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
   test_nic_secondaryip_add_remove | `Error` | 1511.51 | test_multipleips_per_nic.py
   ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
   ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
   ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
   ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
   ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.15 | test_projects.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-887169271


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882916375


   <b>Trillian test result (tid-1310)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 67193 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1310-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 78 look OK, 11 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 1197.35 | test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.11 | test_service_offerings.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 283.18 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 463.77 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-879543588


   <b>Trillian test result (tid-1255)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 60384 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1255-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 84 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_ping_in_cpvm_success | `Failure` | 15.36 | test_diagnostics.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3608.65 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3619.40 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 39.34 | test_kubernetes_clusters.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 350.64 | test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 347.80 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 543.24 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 535.73 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 506.99 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882916375


   <b>Trillian test result (tid-1310)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 67193 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1310-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 78 look OK, 11 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 1197.35 | test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.11 | test_service_offerings.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 283.18 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 463.77 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-793542004


   none of these ^^ errors have to do with this PR afaics.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-878909134


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez closed pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837033936


   @soreana can you fix the conflicts 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837984881


   @DaanHoogland from what I read, apart from me nobody was interested in 4.15 including the author so I didn't push it any further. I just checked branch compatibility and it looks like without rebasing (+ moving any db changes to the right file) this causes conflicts on 4.15. I'm fine with what others have said.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882202916


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882213780


   @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-792745521


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 55


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-880979440


   <b>Trillian test result (tid-1277)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43400 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t1277-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 86 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 344.47 | test_routers_network_ops.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 404.26 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 513.63 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-887184277


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 657


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache closed pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837525868


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd edited a comment on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837984881


   @DaanHoogland from what I read, apart from me nobody was interested in 4.15 including the author so I didn't push it any further. I just checked branch compatibility and it looks like without rebasing (+ moving any db changes to the right file) this causes conflicts on 4.15. I'm fine with what others have said. Also see your https://github.com/apache/cloudstack/pull/4768#issuecomment-797393607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-887184459


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797393607


   @rhtyd (cc @soreana ) though it is a minor change it does include AI and DB changes, so I'd say leave it for 4.16 (that is not a definite :-1: at all, just a expression of our merge principles and principles are there to be broken with)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882203074


   @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez closed pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882213688


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797413805


   > @rhtyd (cc @soreana ) though it is a minor change it does include AI and DB changes, so I'd say leave it for 4.16 (that is not a definite 👎 at all, just a expression of our merge principles and principles are there to be broken with)
   
   @DaanHoogland  let's merge it to 4.16.
   as far as I know, 4.15 accepts only bug fixes and security fixes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-888092805


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-882213411


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 581


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-793185175


   <b>[S] Trillian test result (tid-58)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35742 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4768-t58-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 82 look OK, 4 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 58.83 | test_affinity_groups_projects.py
   test_DeployVmAntiAffinityGroup | `Error` | 35.38 | test_affinity_groups.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 24.62 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_hostha_kvm_host_degraded | `Failure` | 676.75 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Failure` | 642.18 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Failure` | 646.39 | test_hostha_kvm.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-880468311


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] soreana commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
soreana commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837061332


   @rhtyd Done :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-837066734


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez merged pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez closed pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-797341382


   @soreana this looks like a good enhancement. @DaanHoogland @shwstppr should we consider/ask for 4.15.1?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768#issuecomment-888093409


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org