You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 06:16:22 UTC

[GitHub] [arrow-datafusion] stuartcarnie commented on issue #3015: Proposal: Add `date_bin` function

stuartcarnie commented on issue #3015:
URL: https://github.com/apache/arrow-datafusion/issues/3015#issuecomment-1204807984

   @jacobmarble these are great suggestions. 
   
   * PostgreSQL: The `date_bin` implementation accepts a string or an `INTERVAL` type for the first argument. If it is a string, it is parsed as an `INTERVAL`, which saves the user from having to specify the `INTERVAL` prefix. 
       * ✅ Will do that as part of this issue, as it remains compatible with PostgreSQL.
   * PostgreSQL: Supports several formats for `INTERVAL` input expressions, including ISO 8601 intervals, [as noted in the documentation](https://www.postgresql.org/docs/current/datatype-datetime.html#DATATYPE-INTERVAL-INPUT)
       * Fractional seconds support `PT0.nnnnnnS` for microsecond precision. We would extend that to 9 places for nanosecond precision.
   * DataFusion: no support for ISO 8601 interval types, so we can't use shorthand syntax like `PT5S` for 5 seconds.
       * 🗒️ Will need to write a separate issue to add additional `INTERVAL` syntax.
   * DataFusion: We can also support the other data types for the `origin` argument
       * 🙏🏻 I'd like to propose we recommend these extensions in a follow up issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org