You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by s1monw <gi...@git.apache.org> on 2018/10/18 08:17:50 UTC
[GitHub] lucene-solr pull request #480: LUCENE-8535: Drop out of the box Block-Join h...
GitHub user s1monw opened a pull request:
https://github.com/apache/lucene-solr/pull/480
LUCENE-8535: Drop out of the box Block-Join highlight support
Highlighter doesn't support ToParent and ToChildBlockJoinQuery out of the
box anymore. In oder to highlight on Block-Join Queries a custom WeightedSpanTermExtractor
should be used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1monw/lucene-solr LUCENE-8535
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #480
----
commit 6d775d5613700bb01a9d7eb8f44ae9a9acb8b2d2
Author: Simon Willnauer <si...@...>
Date: 2018-10-18T08:15:57Z
LUCENE-8535: Drop out of the box Block-Join highlight support
Highlighter doesn't support ToParent and ToChildBlockJoinQuery out of the
box anymore. In oder to highlight on Block-Join Queries a custom WeightedSpanTermExtractor
should be used.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #480: LUCENE-8535: Drop out of the box Block-Join h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/480
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #480: LUCENE-8535: Drop out of the box Block-Join highligh...
Posted by uschindler <gi...@git.apache.org>.
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/480
Thanks for removing the dependency hell!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #480: LUCENE-8535: Drop out of the box Block-Join highligh...
Posted by s1monw <gi...@git.apache.org>.
Github user s1monw commented on the issue:
https://github.com/apache/lucene-solr/pull/480
@jimczi pushed some changes
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #480: LUCENE-8535: Drop out of the box Block-Join h...
Posted by jimczi <gi...@git.apache.org>.
Github user jimczi commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/480#discussion_r226211884
--- Diff: lucene/CHANGES.txt ---
@@ -123,6 +123,10 @@ Changes in Runtime Behavior
* LUCENE-8505: IndexWriter#addIndices will now fail if the target index is sorted but
the candidate is not. (Jim Ferenczi)
+* LUCENE-8535: Highlighter doesn't support ToParent and ToChildBlockJoinQuery out of the
+ box anymore. In oder to highlight on Block-Join Queries a custom WeightedSpanTermExtractor
--- End diff --
nit: s/oder/order/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org