You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/19 09:46:44 UTC

[GitHub] [incubator-kyuubi] simon824 opened a new pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

simon824 opened a new pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259


   ### _Why are the changes needed?_
   This is a subtask of umbrella issue #KPIP-1
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yanghua edited a comment on pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
yanghua edited a comment on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-946820520


   @simon824 thanks for your contribution.
   
   After serious thinking, I think these two APIs are a bit ugly. It's my problem, No intention to offend you.
   
   I am considering two candidates:
   
   *  `/sessions/execpool/size` & `/sessions/execpool/activecount`
   *  `/sessions/execpool/statistic` which returns a packaged object contains size & activecount and so on
   
   Which one do you prefer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] simon824 commented on pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-947230516


   > @simon824 thanks for your contribution.
   > 
   > After serious thinking, I think these two APIs are a bit ugly. It's my problem, No intention to offend you.
   > 
   > I am considering two candidates:
   > 
   > * `/sessions/execpool/size` & `/sessions/execpool/activecount`
   > * `/sessions/execpool/statistic` which returns a packaged object contains size & activecount and so on
   > 
   > Which one do you prefer?
   
   Thanks a lot for your review , I think option 2 is better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#discussion_r732399485



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -84,4 +83,32 @@ class SessionsResourceSuite extends RestApiBaseSuite {
     }
   }
 
+  @Test
+  def testExecPoolStatistic: Unit = {
+    RestFrontendServiceSuite.withKyuubiRestServer {
+      (restFrontendService: RestFrontendService, _, _) =>
+
+        val sessionManager = restFrontendService.be.sessionManager
+        sessionManager.submitBackgroundOperation(() => {
+          Thread.sleep(3000)
+        })
+
+        // verify the exec pool statistic
+        var response = target("api/v1/sessions/execpool/statistic").request().get()
+        val execPoolStatistic1 = response.readEntity(classOf[ExecPoolStatistic])
+        assert(execPoolStatistic1.execPoolSize == 1 && execPoolStatistic1.execPoolActiveCount == 1)
+
+        Thread.sleep(3000)

Review comment:
       why we need to sleep here, it's flaky and unnecessary ? we can call `future.cancel()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-947254299


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1259](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7aa6416) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/9dfbd2b83064b854d2f21d6370e95bb382f0c482?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9dfbd2b) will **decrease** coverage by `5.74%`.
   > The diff coverage is `44.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1259      +/-   ##
   ============================================
   - Coverage     78.80%   73.06%   -5.75%     
   + Complexity       80       41      -39     
   ============================================
     Files           175      175              
     Lines          6451     6849     +398     
     Branches        764      836      +72     
   ============================================
   - Hits           5084     5004      -80     
   - Misses          923     1444     +521     
   + Partials        444      401      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlFbnN1cmVSZXF1aXJlbWVudHMuc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiSQLExtensionException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxFeHRlbnNpb25FeGNlcHRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...ache/kyuubi/sql/RepartitionBeforeWritingBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9SZXBhcnRpdGlvbkJlZm9yZVdyaXRpbmdCYXNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...ubi/sql/zorder/InsertZorderBeforeWritingBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvSW5zZXJ0Wm9yZGVyQmVmb3JlV3JpdGluZ0Jhc2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [.../kyuubi/sql/zorder/OptimizeZorderCommandBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJDb21tYW5kQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...yuubi/sql/zorder/OptimizeZorderStatementBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJTdGF0ZW1lbnRCYXNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...cala/org/apache/kyuubi/sql/zorder/ZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [94 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9dfbd2b...7aa6416](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yanghua commented on pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-946820520


   @simon824 thanks for your contribution.
   
   After serious thinking, I think these two APIs are a bit ugly.
   
   I am considering two candidates:
   
   *  `/sessions/execpool/size` & `/sessions/execpool/activecount`
   *  `/sessions/execpool/statistic` which returns a packaged object contains size & activecount and so on
   
   Which one do you prefer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#discussion_r732468016



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/SessionsResource.scala
##########
@@ -36,6 +36,13 @@ private[v1] class SessionsResource extends ApiRequestContext {
     SessionOpenCount(backendService.sessionManager.getOpenSessionCount)
   }
 
+  @GET
+  @Path("execpool/statistic")

Review comment:
       not sure `statistic` or `statistics`, what do you think ? cc @simon824 @yaooqinn @yanghua 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-947580151


   thanks , merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#discussion_r731827512



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -84,4 +83,47 @@ class SessionsResourceSuite extends RestApiBaseSuite {
     }
   }
 
+  @Test
+  def testGetExecPoolSize: Unit = {
+    RestFrontendServiceSuite.withKyuubiRestServer {
+      (restFrontendService: RestFrontendService, _, _) =>
+
+        val sessionManager = restFrontendService.serverable.backendService.sessionManager

Review comment:
       restFrontendService.be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] simon824 commented on a change in pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
simon824 commented on a change in pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#discussion_r732486551



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/SessionsResource.scala
##########
@@ -36,6 +36,13 @@ private[v1] class SessionsResource extends ApiRequestContext {
     SessionOpenCount(backendService.sessionManager.getOpenSessionCount)
   }
 
+  @GET
+  @Path("execpool/statistic")

Review comment:
       Statistics is a subject.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-946683604


   cc @yanghua 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1259: [KYUUBI #1258] Implement /sessions/execpoolsize and /sessions/execpoolactivecount

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#discussion_r731827717



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
##########
@@ -84,4 +83,47 @@ class SessionsResourceSuite extends RestApiBaseSuite {
     }
   }
 
+  @Test
+  def testGetExecPoolSize: Unit = {
+    RestFrontendServiceSuite.withKyuubiRestServer {
+      (restFrontendService: RestFrontendService, _, _) =>
+
+        val sessionManager = restFrontendService.serverable.backendService.sessionManager
+        sessionManager.submitBackgroundOperation(() => {
+        })
+        // verify the exec pool size count
+        var response = target("api/v1/sessions/execpoolsize").request().get()
+        val execPoolSize1 = response.readEntity(classOf[ExecPoolSize])
+        assert(execPoolSize1.execPoolSize == 1)
+
+        // verify the exec pool size again after shutdown thread
+        restFrontendService.serverable.backendService.sessionManager.stop()
+        response = target("api/v1/sessions/execpoolsize").request().get()
+        val execPoolSize2 = response.readEntity(classOf[ExecPoolSize])
+        assert(execPoolSize2.execPoolSize == 0)
+    }
+  }
+
+  @Test
+  def testGetExecPoolActiveCount: Unit = {
+    RestFrontendServiceSuite.withKyuubiRestServer {
+      (restFrontendService, _, _) =>
+        val sessionManager = restFrontendService.serverable.backendService.sessionManager

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1259: [KYUUBI #1258] Implement sessions/execpool/statistic

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1259:
URL: https://github.com/apache/incubator-kyuubi/pull/1259#issuecomment-947254299


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1259](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8b92b2d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/9dfbd2b83064b854d2f21d6370e95bb382f0c482?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9dfbd2b) will **decrease** coverage by `5.74%`.
   > The diff coverage is `44.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1259      +/-   ##
   ============================================
   - Coverage     78.80%   73.06%   -5.75%     
   + Complexity       80       41      -39     
   ============================================
     Files           175      175              
     Lines          6451     6849     +398     
     Branches        764      836      +72     
   ============================================
   - Hits           5084     5004      -80     
   - Misses          923     1444     +521     
   + Partials        444      401      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/kyuubi/sql/KyuubiEnsureRequirements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlFbnN1cmVSZXF1aXJlbWVudHMuc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiQueryStagePreparation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlRdWVyeVN0YWdlUHJlcGFyYXRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...pache/kyuubi/sql/KyuubiSQLExtensionException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9LeXV1YmlTUUxFeHRlbnNpb25FeGNlcHRpb24uc2NhbGE=) | `0.00% <ø> (ø)` | |
   | [...ache/kyuubi/sql/RepartitionBeforeWritingBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9SZXBhcnRpdGlvbkJlZm9yZVdyaXRpbmdCYXNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...ubi/sql/zorder/InsertZorderBeforeWritingBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvSW5zZXJ0Wm9yZGVyQmVmb3JlV3JpdGluZ0Jhc2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [.../kyuubi/sql/zorder/OptimizeZorderCommandBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJDb21tYW5kQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...yuubi/sql/zorder/OptimizeZorderStatementBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvT3B0aW1pemVab3JkZXJTdGF0ZW1lbnRCYXNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
   | [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...cala/org/apache/kyuubi/sql/zorder/ZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQmFzZS5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [94 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9dfbd2b...8b92b2d](https://codecov.io/gh/apache/incubator-kyuubi/pull/1259?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org