You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2016/03/21 20:53:42 UTC

svn commit: r1736076 - /uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java

Author: cwiklik
Date: Mon Mar 21 19:53:41 2016
New Revision: 1736076

URL: http://svn.apache.org/viewvc?rev=1736076&view=rev
Log:
UIMA-4866 updated code to prevent counter from getting negative

Modified:
    uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java

Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java?rev=1736076&r1=1736075&r2=1736076&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/RogueProcessReaper.java Mon Mar 21 19:53:41 2016
@@ -128,13 +128,16 @@ public class RogueProcessReaper {
       try {
         // Dont kill the process immediately. Kill if this method is called "counterValue"
         // number of times.
-        @SuppressWarnings("unused")
-        long counter;
+        long counter=0;
         if (logger != null) {
           logger.info(methodName, null,
                   "Decrementing Counter - Current Value:" + entry.counter.getCount());
         }
-        if ((counter = entry.countDown()) == 0 && !entry.isKilled()) {
+        if ( entry.counter.getCount() > 0) {
+        	counter = entry.countDown();
+        }
+        // check if the rogue process needs to be killed
+        if (counter <= 0 && !entry.isKilled()) {
           if (logger == null) {
             System.out.println("Process Scheduled for Kill PID:" + pid + " Owner:" + user + " ");