[jira] Commented: (MYFACES-837) WelcomeFileFilter wants to go to the internet to load web.xml DTD

["Dennis Byrne (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/MYFACES-837?page=comments#action_12365187 ] 

Dennis Byrne commented on MYFACES-837:
--------------------------------------

Is there any reason why you can't use a <DOCTYPE> element, w/ public/system identifiers, or xsi:schemaLocation ?

I agree there is no need for MyFaces to be validating, as the container already does this.

> WelcomeFileFilter wants to go to the internet to load web.xml DTD
> -----------------------------------------------------------------
>
>          Key: MYFACES-837
>          URL: http://issues.apache.org/jira/browse/MYFACES-837
>      Project: MyFaces
>         Type: Bug
>   Components: Implementation
>     Versions: 1.1.2, 1.1.1
>     Reporter: Henning Schmiedehausen

>
> The WelcomeFileFilter loads the webapp web.xml to parse the web.xml file for welcome files (see WelcomeFileFilter, line 180). However as most web.xml files contain a DTD definition, it tries to download these from the web. If the webapp can't reach the internet (firewall, no network connection), the filter fails (in my case with an UnknownHostException).
> IMHO, if the filter insists on parsing the web.xml, it should either be able to resolve the most common DTDs (web-app_2_2.dtd, 2_3.dtd, 2_4.dtd probaby) locally or not use a validating parser (setValidating(false) in line 181)) so that it is possible to use the WelcomeFileFilter on hosts that cannot reach the internet.
> The bug is still present in the current impl trunk at http://svn.apache.org/viewcvs.cgi/myfaces/impl/trunk/src/java/org/apache/myfaces/webapp/filter/WelcomeFileFilter.java?rev=193014&view=markup

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira