[GitHub] [arrow] mapleFU commented on issue #35776: [C++][Parquet] Should we support PARQUET_2_8 version?

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on issue #35776:
URL: https://github.com/apache/arrow/issues/35776#issuecomment-1578886910

   I guess it's a big hard, because checking is separted to different places...
   
   1. under `FieldToNode` in `src/parquet/arrow/schema.cc`
   
   ```c++
       case ArrowTypeId::TIMESTAMP:
         RETURN_NOT_OK(
             GetTimestampMetadata(static_cast<::arrow::TimestampType&>(*field->type()),
                                  properties, arrow_properties, &type, &logical_type));
         break;
   ```
   
   2. https://github.com/apache/arrow/blob/2d32efeedad88743dd635ff562c65e072cfb44f7/cpp/src/parquet/column_writer.cc#L2062-L2072 when write timestamp
   
   I guess we need a `validate_format` like:
   
   ```c++
   validate_format(const WriterProperties& properties, const ArrowWriterProperties& arrow_properties, Schema);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org