You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/13 05:34:17 UTC

[kudu-CR](branch-1.17.x) [gutil] fix ASAN warning in CountOnes()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20573


Change subject: [gutil] fix ASAN warning in CountOnes()
......................................................................

[gutil] fix ASAN warning in CountOnes()

Running various tests on aarch64 (Graviton3) under ASAN produced
warnings like below:

  src/kudu/gutil/bits.h:19:42: runtime error: unsigned integer overflow:
    134678536 * 16843009 cannot be represented in type 'unsigned int'
      #0 0xffffa1ebd8d4 in Bits::CountOnes(unsigned int) src/kudu/gutil/bits.h:19:42
      #1 0xffffa1ebd830 in Bits::CountOnes64(unsigned long) src/kudu/gutil/bits.h:30:12
      #2 0xffffa1ebd7f8 in Bits::CountOnes64withPopcount(unsigned long) src/kudu/gutil/bits.h:43:12

  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/kudu/gutil/bits.h:19:42

This patch addresses the issue.

Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Reviewed-on: http://gerrit.cloudera.org:8080/20558
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 8aab39e8b7601c75b0c516c82f1ea6b85c5cfcd6)
---
M src/kudu/gutil/bits.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/20573/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Gerrit-Change-Number: 20573
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [gutil] fix ASAN warning in CountOnes()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20573 )

Change subject: [gutil] fix ASAN warning in CountOnes()
......................................................................

[gutil] fix ASAN warning in CountOnes()

Running various tests on aarch64 (Graviton3) under ASAN produced
warnings like below:

  src/kudu/gutil/bits.h:19:42: runtime error: unsigned integer overflow:
    134678536 * 16843009 cannot be represented in type 'unsigned int'
      #0 0xffffa1ebd8d4 in Bits::CountOnes(unsigned int) src/kudu/gutil/bits.h:19:42
      #1 0xffffa1ebd830 in Bits::CountOnes64(unsigned long) src/kudu/gutil/bits.h:30:12
      #2 0xffffa1ebd7f8 in Bits::CountOnes64withPopcount(unsigned long) src/kudu/gutil/bits.h:43:12

  SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior src/kudu/gutil/bits.h:19:42

This patch addresses the issue.

Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Reviewed-on: http://gerrit.cloudera.org:8080/20558
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 8aab39e8b7601c75b0c516c82f1ea6b85c5cfcd6)
Reviewed-on: http://gerrit.cloudera.org:8080/20573
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/gutil/bits.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/20573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Gerrit-Change-Number: 20573
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR](branch-1.17.x) [gutil] fix ASAN warning in CountOnes()

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20573 )

Change subject: [gutil] fix ASAN warning in CountOnes()
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Gerrit-Change-Number: 20573
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sun, 15 Oct 2023 16:35:54 +0000
Gerrit-HasComments: No