You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/16 06:02:21 UTC

[GitHub] [beam] reuvenlax commented on issue #11041: Use beam join api in sql

reuvenlax commented on issue #11041: Use beam join api in sql
URL: https://github.com/apache/beam/pull/11041#issuecomment-599360130
 
 
   @kennknowles This PR still needs some comments and unit tests, but what do you think? It pulls most of the complexity of the join transforms into the generic schema Join transform. A lot of code is deleted. Could've deleted even more code, except it's being used by "lookup" joins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services