[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29978: Sync v2-5-stable with v2-5-test to release 2.5.2

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #29978:
URL: https://github.com/apache/airflow/pull/29978#discussion_r1130200950


##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,113 @@
 
 .. towncrier release notes start
 
+Airflow 2.5.2 (2023-03-13)
+--------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+The date-time fields passed as API parameters or Params should be RFC3339-compliant (#29395)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+  In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
+  such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).
+
+  In case of parameters, we still allow IS8601-compliant date-time (so for example it is possible that
+  ' ' was used instead of ``T`` separating date from time and no timezone was specified) but we raise
+  deprecation warning. (#29395)

Review Comment:
   Indeed.
   
   The output of:
   ```
   towncrier build --version=${VERSION_WITHOUT_RC} --date=2023-03-14 --dir . --config newsfragments/config.toml
   ```
   Is not `rst` formatted. So basically I end up editing and formatting this manually, to be consistent with previous releases.
   This leave space for inconsistencies.
   
   Same for the body of the changelog which comes from the following command, there is quite a few manual formatting operations here as well.
   ```
   ./dev/airflow-github changelog  v2-5-stable  v2-5-test
   ```
   
   This is something I wanted to ask @ephraimbuddy, maybe there is a better way for building the release note I am not aware of.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org