You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/03/01 20:52:41 UTC

Re: Review Request: Add missing operations for Attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3957/
-----------------------------------------------------------

(Updated 2012-03-01 19:52:41.813542)


Review request for mesos and Benjamin Hindman.


Summary
-------

I noticed that Attributes were missing an implementation of get() (despite a prototype) and of operator==. This patch adds them.

In the process, it does some other minor fixes:
- operator== for Value::* types are moved to common/values.{hpp,cpp}
- tests/attributes_tests.cpp is added as a source of mesos-tests (it was previously not being compiled!)


Diffs (updated)
-----

  src/Makefile.am 5ed41bf 
  src/common/attributes.hpp 210ceda 
  src/common/resources.hpp e4a826d 
  src/common/resources.cpp b036e42 
  src/common/values.hpp 902a3d2 
  src/common/values.cpp efe6859 
  src/tests/attributes_test.cpp 3ceb48f 

Diff: https://reviews.apache.org/r/3957/diff


Testing
-------


Thanks,

Charles