You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 14:57:53 UTC

[GitHub] [spark] AngersZhuuuu opened a new pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

AngersZhuuuu opened a new pull request #31727:
URL: https://github.com/apache/spark/pull/31727


   ### What changes were proposed in this pull request?
   In the PR, I propose to generate "stable" output attributes per the logical node of the DESCRIBE COLUMN command.
   
   
   ### Why are the changes needed?
   This fixes the issue demonstrated by the example:
   
   ```
   val tbl = "testcat.ns1.ns2.tbl"
   sql(s"CREATE TABLE $tbl (c0 INT) USING _")
   val description = sql(s"DESCRIBE TABLE $tbl c0")
   description.drop("info_name")
   ```
   
   ```
   [info]   org.apache.spark.sql.AnalysisException: Resolved attribute(s) info_name#74 missing from info_name#25,info_value#26 in operator !Project [info_name#74]. Attribute(s) with the same name appear in the operation: info_name. Please check if the right attribute(s) are used.;
   [info] !Project [info_name#74]
   [info] +- LocalRelation [info_name#25, info_value#26]
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   After this change user `drop()/add()` works well.
   
   ### How was this patch tested?
   Added UT
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789875922


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40296/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790233494


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu closed pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #31727:
URL: https://github.com/apache/spark/pull/31727


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789875922


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40296/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790247999


   **[Test build #135728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135728/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790298669


   seems like a real test failure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790298960


   @cloud-fan Seems we should backport more pr to 3.1 branch according to the failed test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790283006


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40310/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AngersZhuuuu commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789774004


   FYI @cloud-fan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789795738


   **[Test build #135714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135714/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789926868


   **[Test build #135714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135714/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789795738


   **[Test build #135714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135714/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790289936






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790289936






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790273960


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40310/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790247999


   **[Test build #135728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135728/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790285480


   **[Test build #135728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135728/testReport)** for PR 31727 at commit [`6e79c5c`](https://github.com/apache/spark/commit/6e79c5c926c40e07531fbd1b8169814e3e4e0ad3).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-790306088


   ah we don't have v2 DESC COLUMN in 3.1, so the bug doesn't exist there. Let's close this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789835096


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40296/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789875877


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40296/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789933222


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135714/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31727: [SPARK-34576][SQL][3.1] Fix drop/add columns to a dataset of `DESCRIBE COLUMN`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31727:
URL: https://github.com/apache/spark/pull/31727#issuecomment-789933222


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135714/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org