[jira] [Commented] (HBASE-19887) Do not overwrite the surefire junit listener property in the pom of sub modules

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344580#comment-16344580 ] 

stack commented on HBASE-19887:
-------------------------------

Yes go for it.

These resource checker/server resource checker are useful util added long ago.

In branch-1.3 at least there is a difference.
{code:java}
static class ConnectionCountResourceAnalyzer extends ResourceChecker.ResourceAnalyzer {
  @Override
  public int getVal(Phase phase) {
    return HConnectionTestingUtility.getConnectionCount();
  }
}

@Override
protected void addResourceAnalyzer(ResourceChecker rc) {
  rc.addResourceAnalyzer(new ConnectionCountResourceAnalyzer());
}{code}
Does our new ClassRule do what these listeners used to do? It doesn't seem too. Will I add it into ./hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRuleChecker.java ? 

Thanks [~Apache9]

> Do not overwrite the surefire junit listener property in the pom of sub modules
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-19887
>                 URL: https://issues.apache.org/jira/browse/HBASE-19887
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-19887.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)