You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/19 03:56:00 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new issue, #21643: Make the license header consistent.
RaigorJiang opened a new issue, #21643:
URL: https://github.com/apache/shardingsphere/issues/21643
Hi community,
I found that part of the license header format in the project is inconsistent (but the content is consistent)
E.g:
- `.licenserc.yaml`
```yaml
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
...
```
But the license header of **MORE FILES** is like this:
- `.codecov.yml`
```yaml
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
...
```
Other files with differences are
- mvnw
- mvnw.cmd
- .gitattributes
- .github/workflows/nightly-graalvm-image.yml
- .mvn/wrapper/maven-wrapper.properties
- src/resources/spotless_shardingsphere_formatter.xml
> Specifically `spotless_shardingsphere_formatter.xml`, Its xml comment format is different from others
I think they should be adjusted to a uniform format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290929685
@linghengqian @RaigorJiang As this File is deleted so it's header can't be changed , so all the other files are adjusted to a uniform format you can merge the PR #21755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290027571
Hi @DivvSaxena,
Thanks for your attention. We just need to update the license header of the above file to the same format as the other ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1294866107
@RaigorJiang Check it now i fixed that problem , I think now it should get merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1292231280
@RaigorJiang Solved that problem for the XML file made commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1293299313
@RaigorJiang Check it now modified the other part to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1293341823
@DivvSaxena Thank you. But I found that there are still differences in the files, can you compare other ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290284087
Yes, it should be easy to get started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290809341
Hey @RaigorJiang, I am not able to find this file .github/workflows/nightly-graalvm-image.yml .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1292206196
@DivvSaxena
Thanks for the PR, I left a comment for the XML file in it, please check it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1295647827
Fixed by #21755.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290257310
Hey @RaigorJiang ,
I think i can do it , assign it to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1290881883
> Hey @RaigorJiang, I am not able to find this file .github/workflows/nightly-graalvm-image.yml and
> Check the PR #21755
- FYI, this file was deleted some time ago. Refer to https://github.com/apache/shardingsphere/pull/21677 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1289985111
how can i contribute to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1295647601
@DivvSaxena CI passed, merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang closed issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #21643: Make the license header consistent.
URL: https://github.com/apache/shardingsphere/issues/21643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DivvSaxena commented on issue #21643: Make the license header consistent.
Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on issue #21643:
URL: https://github.com/apache/shardingsphere/issues/21643#issuecomment-1295710754
@RaigorJiang Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org