You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2009/09/10 20:22:58 UTC
[jira] Created: (HBASE-1822) Remove the deprecated APIs
Remove the deprecated APIs
--------------------------
Key: HBASE-1822
URL: https://issues.apache.org/jira/browse/HBASE-1822
Project: Hadoop HBase
Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Jonathan Gray
Fix For: 0.21.0
Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753842#action_12753842 ]
Andrew Purtell commented on HBASE-1822:
---------------------------------------
I don't think Scan or Get methods which take old-style byte[][] arguments are necessary, but KeyValue.parseColumn is useful for at least Stargate. It's convenient to use column:qualifier syntactic sugar in RESTful resource specifications.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755776#action_12755776 ]
stack commented on HBASE-1822:
------------------------------
I'd say just commit once all tests pass. Remove TestStoreFile tests that do HSK... Remove whole test if you can't move it over.
This is a big change. Get it in now while we are being fast and loose with TRUNK.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray resolved HBASE-1822.
----------------------------------
Resolution: Fixed
Release Note: Removed deprecated API calls and internal references to family:qualifier notation.
Hadoop Flags: [Incompatible change, Reviewed]
This has been committed to trunk. (25,000 line patch, eek)
It completely removes the old API and is an attempt at removing all remaining references to family:qualifier notation. It drops the mapred and rest packages completely, in favor of the new mapreduce package and stargate. Things like HStoreKey, RowResult, and BatchUpdate are gone.
The only remaining calls related to fam:qf notation are KeyValue.makeColumn(fam,qf) and KeyValue.parseColumn(col) which takes a byte[] and splits it on the :. If it's just family it returns a single dimension only with the family in it, no :. This switched a bit as to how it worked, and it's used heavily in my adapting Thrift, Stargate, and Transactional/Indexed to work and pass their tests after ripping out old API calls they were using.
Those same contrib modules (should we move thrift to contrib?) really need a reworking of some sort (stargate is probably fine, except some nastiness in tests), as they are heavily tied to the old API and their new API compatibility was just a bolt on.
So this may have destabilized trunk a bit. Please file issues if you run into problems.
All unit tests pass.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch, HBASE-1822-v3.patch, HBASE-1822-v5.patch, HBASE-1822-v6.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1822:
---------------------------------
Attachment: HBASE-1822-v6.patch
I believe all tests are passing with this patch. Doing one final run and then will commit.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch, HBASE-1822-v3.patch, HBASE-1822-v5.patch, HBASE-1822-v6.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753955#action_12753955 ]
Jonathan Gray commented on HBASE-1822:
--------------------------------------
Indexed stuff uses fam:col everywhere, often times just fam:... I've fixed much of it but it's a pain and I'm worried I might break it.
@Clint Do you want to try to clean it up, or shall I proceed?
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1822:
---------------------------------
Attachment: HBASE-1822-v3.patch
Fixed TestStoreFile, passes.
Running more tests now.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch, HBASE-1822-v3.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753796#action_12753796 ]
Andrew Purtell commented on HBASE-1822:
---------------------------------------
What are the errors for Stargate?
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753922#action_12753922 ]
stack commented on HBASE-1822:
------------------------------
I'm good w/ axing the band-aid methods that took old style family:qualifier.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1822:
---------------------------------
Attachment: HBASE-1822-v1.patch
First go.
REST, Transactional, and Stargate still have errors. Didn't want to touch those until we decided which would be removed for 0.21 or how that is going to work.
Otherwise all tests compile, have not run them all. Removed old api tests as well.
Only test that needs to be reworked (using a lot of HSK for some reason, though should be KV) is o.a.h.h.regionserver.TestStoreFile.
Whee that was fun.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1822:
---------------------------------
Attachment: HBASE-1822-v5.patch
Another version of the patch. Lots of tests pass, need to run more though.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch, HBASE-1822-v3.patch, HBASE-1822-v5.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753749#action_12753749 ]
Jean-Daniel Cryans commented on HBASE-1822:
-------------------------------------------
And remove the nineteen migration package.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753818#action_12753818 ]
Jonathan Gray commented on HBASE-1822:
--------------------------------------
Easy to fix error in Stargate.
But it brings up a question. There are uses all over the place of family:qualifier treated together in a single byte[], often times it's byte [][] columns.
I took those APIs out of Scan/Get because they are old-API and there has been confusion from new users (email on the list today that was at least partially misusing it).
Do we want to retain something in Scan/Get, rework consumers who are using byte [][] columns, or just deal with iterating and disassembling it (that's what I've done so far).
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-1822:
---------------------------------
Attachment: HBASE-1822-v2.patch
Everything compiles with this patch except for o.a.h.h.regionserver.TestStoreFile which contains a bunch of odd usage of new HStoreKey(midkey). An attempt at moving it to KVs resulted in the tests not passing.
Removes REST in favor of stargate contrib.
Hacky fixes on stargate, indexed, and thrift until the authors go back through and rework their internal APIs to be more friendly to the current API (though this might not be necessary, up to the authors).
Need to run more tests, though I ran many as I went.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch, HBASE-1822-v2.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-1822) Remove the deprecated APIs
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753844#action_12753844 ]
Jonathan Gray commented on HBASE-1822:
--------------------------------------
That's exactly what I did. I'm using KV.parseColumn internally.
> Remove the deprecated APIs
> --------------------------
>
> Key: HBASE-1822
> URL: https://issues.apache.org/jira/browse/HBASE-1822
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jean-Daniel Cryans
> Assignee: Jonathan Gray
> Fix For: 0.21.0
>
> Attachments: HBASE-1822-v1.patch
>
>
> Remove all the deprecated stuff in client and mapred.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.