You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/02/08 22:28:35 UTC
[GitHub] [logging-log4j2] turbanoff commented on a change in pull request
#338: use 'final' modifier for fields where possible
turbanoff commented on a change in pull request #338: use 'final' modifier for fields where possible
URL: https://github.com/apache/logging-log4j2/pull/338#discussion_r376738565
##########
File path: log4j-1.2-api/src/main/java/org/apache/log4j/spi/ThrowableInformation.java
##########
@@ -29,8 +29,8 @@
static final long serialVersionUID = -4748765566864322735L;
- private transient Throwable throwable;
- private Method toStringList;
+ private final transient Throwable throwable;
Review comment:
Can you please elaborate? I don't see reasons to not do them `final`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services