You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/22 08:48:07 UTC
[GitHub] [systemml] sebwrede commented on a change in pull request #895: Privacy Metadata initial
sebwrede commented on a change in pull request #895:
URL: https://github.com/apache/systemml/pull/895#discussion_r412793957
##########
File path: src/main/java/org/tugraz/sysds/parser/DataExpression.java
##########
@@ -109,31 +113,70 @@
public static final String DELIM_SPARSE = "sparse"; // applicable only for write
- public static final String[] RAND_VALID_PARAM_NAMES =
- {RAND_ROWS, RAND_COLS, RAND_DIMS, RAND_MIN, RAND_MAX, RAND_SPARSITY, RAND_SEED, RAND_PDF, RAND_LAMBDA};
+ public static final Set<String> RAND_VALID_PARAM_NAMES =
Review comment:
I needed to add privacy to the parameter array and then I noticed inconsistencies in how parameters are checked using the arrays, so I decided to change it. It could easily be a separate PR and I will try to be better at making this kind of update in separate PRs in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org