You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/04/11 15:00:29 UTC

[GitHub] wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods

wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects methods
URL: https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104
 
 
   @nikitap492  Thanks. That is better to understand your pr. Then I will focus on codes only for this pr.
   
   At least, we need to make sure there is no bug caused by this. Right? :) 
   
   > Could you look at InstanceCacheGuavaService, for example. The methods getApplicationId , getInstanceIdByAgentUUID and getInstanceIdByAddressId had very similar code and few difference. I tried to generalize it.
   
   For `InstanceCacheService`, you can try to refactor it. But don't try to merge these two method signatures.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services