You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/03 13:02:51 UTC

[GitHub] [commons-compress] XenoAmess commented on pull request #106: [COMPRESS-535] maybe we can add a break here

XenoAmess commented on pull request #106:
URL: https://github.com/apache/commons-compress/pull/106#issuecomment-638181991


   >In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. 
   
   OK, I will find some time to do the test.
   I will also try build a data structure for this question, and test performance for it too.
   
   And, maybe we should not merge this pr until the test result comes? 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org