You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/09 21:08:05 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #9532: [Broker] Async read entries with max size bytes

merlimat commented on a change in pull request #9532:
URL: https://github.com/apache/pulsar/pull/9532#discussion_r573240783



##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
##########
@@ -463,6 +463,42 @@ public void readEntriesFailed(ManagedLedgerException exception, Object ctx) {
         counter.await();
     }
 
+    @Test(timeOut = 20000)
+    void testAsyncReadWithMaxSizeByte() throws Exception {
+        ManagedLedger ledger = factory.open("testAsyncReadWithMaxSizeByte");
+        ManagedCursor cursor = ledger.openCursor("c1");

Review comment:
       That's ok in these tests, the factory gets re-created after each test and it automatically closes everything in the shutdown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org