[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6892: Externalize KVM HA heartbeat frequency

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1080947374


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
     private long _timeout = 60000; /* 1 minutes */
     protected static String s_heartBeatPath;
     protected long _heartBeatUpdateTimeout = 60000;
-    protected long _heartBeatUpdateFreq = 60000;
+    protected long _heartBeatUpdateFreq = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);

Review Comment:
   before this becomes a an even more big discussion: let's stick to the question of whetther we keep it to this setting and go through the trouble of testing new PRs when we want other setting, or we add as much settings as we can now?
   I see the rest of the discussion as useful, no doubt but it kind of transcends this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org