[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #1748: 17737 4.0

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #1748:
URL: https://github.com/apache/cassandra/pull/1748#discussion_r929089173


##########
src/java/org/apache/cassandra/service/GCInspector.java:
##########
@@ -55,7 +55,7 @@ public class GCInspector implements NotificationListener, GCInspectorMXBean
     public static final String MBEAN_NAME = "org.apache.cassandra.service:type=GCInspector";
     private static final Logger logger = LoggerFactory.getLogger(GCInspector.class);
     private volatile long gcLogThreshholdInMs = DatabaseDescriptor.getGCLogThreshold();
-    private volatile long gcWarnThreasholdInMs = DatabaseDescriptor.getGCWarnThreshold();
+    private volatile long gcWarnThresholdInMs = DatabaseDescriptor.getGCWarnThreshold();

Review Comment:
   So what you suggest is just to make them volatile also in Config? And the long-int issue is already solved in the setter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org