You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <ke...@freestoneinfotech.com> on 2016/05/24 14:01:12 UTC
Review Request 47775: ATLAS-812 : Atlas UI - Associate Terms with
Assets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47775/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Bugs: ATLAS-812
https://issues.apache.org/jira/browse/ATLAS-812
Repository: atlas
Description
-------
**Attached Patch contains:**
**1) Association of Terms with Assets.**
a) Now, allowing users to associate and dis-associate Terms with Assets from DSL search results page.
b) Also allowing users to dis-associate Terms with Assets from Asset details page.
**2) Showing associated Terms in asset details view in a tab same as that of Tags.**
**Note::** Currently we have implemented a workaround to show Terms separately from Entity object's list of Traits (i.e. showing all traits which has " . " in it as Terms).
As and when we have list of terms in Entities or entity object, we will have to mke UI changes accordingly.
Diffs
-----
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html ddb7eac
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 633d497
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html db827a3
dashboardv2/public/js/utils/CommonViewFunction.js ff0f2d2
dashboardv2/public/js/utils/Utils.js 4f57055
dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 665d5c6
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 6b4d05b
dashboardv2/public/js/views/search/SearchResultLayoutView.js e2981d1
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 901130a
Diff: https://reviews.apache.org/r/47775/diff/
Testing
-------
Verified Tag association functionality on Atlas UI manually.
Thanks,
keval bhatt
Re: Review Request 47775: ATLAS-812 : Atlas UI - Associate Terms with
Assets
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47775/
-----------------------------------------------------------
(Updated May 25, 2016, 2:22 p.m.)
Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Changes
-------
Resolved all feedbacks from Hemanth on apache JIRA.
Left navigation related changes are not done in this patch, as I am sending another patch which will have all the changes for making left navigation very user friendly for browsing Terms using arrow (ATLAS-821)
Bugs: ATLAS-812
https://issues.apache.org/jira/browse/ATLAS-812
Repository: atlas
Description
-------
**Attached Patch contains:**
**1) Association of Terms with Assets.**
a) Now, allowing users to associate and dis-associate Terms with Assets from DSL search results page.
b) Also allowing users to dis-associate Terms with Assets from Asset details page.
**2) Showing associated Terms in asset details view in a tab same as that of Tags.**
**Note::** Currently we have implemented a workaround to show Terms separately from Entity object's list of Traits (i.e. showing all traits which has " . " in it as Terms).
As and when we have list of terms in Entities or entity object, we will have to mke UI changes accordingly.
Diffs (updated)
-----
dashboardv2/public/css/scss/tag.scss 5ba0fca
dashboardv2/public/css/scss/theme.scss 1c59450
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html ddb7eac
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 633d497
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html db827a3
dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html e4973de
dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 5de9e00
dashboardv2/public/js/utils/CommonViewFunction.js ff0f2d2
dashboardv2/public/js/utils/Utils.js 4f57055
dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 665d5c6
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 6b4d05b
dashboardv2/public/js/views/schema/SchemaLayoutView.js 2ed285f
dashboardv2/public/js/views/search/SearchResultLayoutView.js e2981d1
dashboardv2/public/js/views/tag/CreateTagLayoutView.js 8dcb9cf
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 901130a
dashboardv2/public/js/views/tag/TagLayoutView.js 9580ad1
dashboardv2/public/js/views/tag/addTagModalView.js 0601cce
Diff: https://reviews.apache.org/r/47775/diff/
Testing
-------
Verified Term association functionality on Atlas UI manually.
Thanks,
keval bhatt
Re: Review Request 47775: ATLAS-812 : Atlas UI - Associate Terms with
Assets
Posted by keval bhatt <ke...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47775/
-----------------------------------------------------------
(Updated May 24, 2016, 2:03 p.m.)
Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, and Hemanth Yamijala.
Bugs: ATLAS-812
https://issues.apache.org/jira/browse/ATLAS-812
Repository: atlas
Description
-------
**Attached Patch contains:**
**1) Association of Terms with Assets.**
a) Now, allowing users to associate and dis-associate Terms with Assets from DSL search results page.
b) Also allowing users to dis-associate Terms with Assets from Asset details page.
**2) Showing associated Terms in asset details view in a tab same as that of Tags.**
**Note::** Currently we have implemented a workaround to show Terms separately from Entity object's list of Traits (i.e. showing all traits which has " . " in it as Terms).
As and when we have list of terms in Entities or entity object, we will have to mke UI changes accordingly.
Diffs
-----
dashboardv2/public/js/templates/business_catalog/AddTermToEntityLayoutView_tmpl.html PRE-CREATION
dashboardv2/public/js/templates/business_catalog/AddTermView_tmpl.html ddb7eac
dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 633d497
dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html db827a3
dashboardv2/public/js/utils/CommonViewFunction.js ff0f2d2
dashboardv2/public/js/utils/Utils.js 4f57055
dashboardv2/public/js/views/business_catalog/AddTermToEntityLayoutView.js PRE-CREATION
dashboardv2/public/js/views/business_catalog/BusinessCatalogDetailLayoutView.js 665d5c6
dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 6b4d05b
dashboardv2/public/js/views/search/SearchResultLayoutView.js e2981d1
dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 901130a
Diff: https://reviews.apache.org/r/47775/diff/
Testing (updated)
-------
Verified Term association functionality on Atlas UI manually.
Thanks,
keval bhatt