You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hc.apache.org by se...@apache.org on 2011/01/06 04:05:56 UTC

svn commit: r1055726 - /httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java

Author: sebb
Date: Thu Jan  6 03:05:55 2011
New Revision: 1055726

URL: http://svn.apache.org/viewvc?rev=1055726&view=rev
Log:
Not @Immutable, but it is @ThreadSafe

Modified:
    httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java?rev=1055726&r1=1055725&r2=1055726&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java (original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/BasicIdGenerator.java Thu Jan  6 03:05:55 2011
@@ -33,17 +33,19 @@ import java.security.SecureRandom;
 import java.util.Formatter;
 import java.util.Locale;
 
-import org.apache.http.annotation.Immutable;
+import org.apache.http.annotation.GuardedBy;
+import org.apache.http.annotation.ThreadSafe;
 
 /**
  * Should produce reasonably unique tokens.
  */
-@Immutable
+@ThreadSafe
 class BasicIdGenerator {
 
     private final String hostname;
     private final SecureRandom rnd;
 
+    @GuardedBy("this")
     private long count;
 
     public BasicIdGenerator() {