You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "takraj (via GitHub)" <gi...@apache.org> on 2023/10/19 10:42:34 UTC

[PR] feat(plc4x-server): Build a standalone jar too

takraj opened a new pull request, #1167:
URL: https://github.com/apache/plc4x/pull/1167

   Build a fat jar that contains all the dependencies, so user can set up a plc4x proxy server much easier.
   
   ```
   $ java -jar plc4j-plc4x-server-0.12.0-SNAPSHOT-uber-jar.jar
   11:50:07.822 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory -- Using SLF4J as the default logging framework
   11:50:07.826 [main] DEBUG io.netty.channel.MultithreadEventLoopGroup -- -Dio.netty.eventLoopThreads: 24
   11:50:07.833 [main] DEBUG io.netty.util.concurrent.GlobalEventExecutor -- -Dio.netty.globalEventExecutor.quietPeriodSeconds: 1
   11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.initialSize: 1024
   11:50:07.839 [main] DEBUG io.netty.util.internal.InternalThreadLocalMap -- -Dio.netty.threadLocalMap.stringBuilder.maxSize: 4096
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(plc4x-server): Build a standalone jar too

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1167:
URL: https://github.com/apache/plc4x/pull/1167#issuecomment-1773077042

   No objections to building fat jars, however I would not want to use these as maven dependencies in the project.
   
   Also do I think that we don't need to explicitly attach the uber-jar as I think I remember the shade plugin does that for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(plc4x-server): Build a standalone jar too

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz merged PR #1167:
URL: https://github.com/apache/plc4x/pull/1167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(plc4x-server): Build a standalone jar too

Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on PR #1167:
URL: https://github.com/apache/plc4x/pull/1167#issuecomment-1772251713

   LGTM, @chrisdutz any objections?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(plc4x-server): Build a standalone jar too

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #1167:
URL: https://github.com/apache/plc4x/pull/1167#issuecomment-1773826514

   Just noticed that you're only talking about the server ... sure ... that's not used from anywhere else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org