You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/30 13:53:21 UTC

[GitHub] duhenglucky commented on a change in pull request #735: [ISSUE#731] Delete unnecessary logs in TransactionalMessageServiceImpl

duhenglucky commented on a change in pull request #735: [ISSUE#731] Delete unnecessary logs in TransactionalMessageServiceImpl
URL: https://github.com/apache/rocketmq/pull/735#discussion_r252263726
 
 

 ##########
 File path: broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java
 ##########
 @@ -100,13 +100,6 @@ private boolean putBackHalfMsgQueue(MessageExt msgExt, long offset) {
             msgExt.setCommitLogOffset(
                 putMessageResult.getAppendMessageResult().getWroteOffset());
             msgExt.setMsgId(putMessageResult.getAppendMessageResult().getMsgId());
-            log.info(
 
 Review comment:
   Maybe make the log level to debug level is a better choice, because if we deleted all log, we will lose all hint to locate the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services