You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/14 07:29:56 UTC
[GitHub] [avro] martin-g opened a new pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
martin-g opened a new pull request #1459:
URL: https://github.com/apache/avro/pull/1459
Ignore compilation warnings that member fields are not Serializable
### Jira
- [X] My PR addresses the following [AVRO-3306](https://issues.apache.org/jira/browse/AVRO-3306) issue.
### Tests
- [X] My PR reuses the old unit tests.
### Commits
- [X] My commits all reference Jira issues in their subject lines.
### Documentation
- [X] No need of new documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1459:
URL: https://github.com/apache/avro/pull/1459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a change in pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1459:
URL: https://github.com/apache/avro/pull/1459#discussion_r784851701
##########
File path: .github/workflows/test-lang-java.yml
##########
@@ -39,6 +39,7 @@ jobs:
- '8'
- '11'
- '17'
+ - '18-ea'
Review comment:
we can't :-)
see the commit history in the PR. First I tried with 19-ea but it seems it is not yet available via the `setup-java` action.
I've tried it locally though and everything is fine after these changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on a change in pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
Posted by GitBox <gi...@apache.org>.
iemejia commented on a change in pull request #1459:
URL: https://github.com/apache/avro/pull/1459#discussion_r784840037
##########
File path: .github/workflows/test-lang-java.yml
##########
@@ -39,6 +39,7 @@ jobs:
- '8'
- '11'
- '17'
+ - '18-ea'
Review comment:
wondering if we can already target 19-ea here since it is already out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on a change in pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1459:
URL: https://github.com/apache/avro/pull/1459#discussion_r785154970
##########
File path: .github/workflows/test-lang-java.yml
##########
@@ -39,6 +39,7 @@ jobs:
- '8'
- '11'
- '17'
+ - '18-ea'
Review comment:
I wasn't able to find any distribution listed at https://github.com/actions/setup-java#supported-distributions that provides 19-ea at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1459: AVRO-3306: Java: Build failure with JDK 18+
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1459:
URL: https://github.com/apache/avro/pull/1459#issuecomment-1013107217
Note for the future, we in Avro support LTS versions, support for intermediary versions is best-effort, cool work @martin-g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org