You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/11/26 08:34:19 UTC
[GitHub] [incubator-inlong] huzk8 opened a new pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
huzk8 opened a new pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846
### Title Name: [INLONG-XYZ][component] Title of the pull request
where *XYZ* should be replaced by the actual issue number.
Fixes #1821
### Motivation
add sort support doris sink
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? ( docs )
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang merged pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-985172439
@huzk8 thanks for this contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-981217562
```
[INFO] 开始检查……
Error: /home/runner/work/incubator-inlong/incubator-inlong/inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/sink/DorisSinkInfo.java:77: 'METHOD_DEF' 前只应有一个空行。 [EmptyLineSeparator]
检查完成。
[INFO] There is 1 error reported by Checkstyle 8.29 with codestyle/checkstyle.xml ruleset.
Error: src/main/java/org/apache/inlong/sort/protocol/sink/DorisSinkInfo.java:[77] (whitespace) EmptyLineSeparator: 'METHOD_DEF' 前只应有一个空行。
```
@huzk8 please check this error, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] huzk8 commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
huzk8 commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-984535516
> @huzk8, there are several review comments that you need to modify
the `inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/flink/doris/load/DorisRespond.java` is already modify in commit #e3fe9df
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] huzk8 commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
huzk8 commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-984536744
> @huzk8, there are several review comments that you need to modify
could you tell me more detail about which file need to modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on a change in pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#discussion_r758246724
##########
File path: inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/flink/doris/load/BeInfoResponse.java
##########
@@ -0,0 +1,45 @@
+package org.apache.inlong.sort.flink.doris.load;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * @program: incubator-inlong
+ * @author: huzekang
Review comment:
the same problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on a change in pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#discussion_r757356622
##########
File path: inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/flink/doris/TestDorisSink.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.inlong.sort.flink.doris;
+
+import org.apache.flink.api.java.ExecutionEnvironment;
+import org.apache.flink.api.java.operators.DataSource;
+import org.apache.flink.types.Row;
+import org.apache.inlong.sort.flink.doris.output.DorisOutputFormat;
+import org.apache.inlong.sort.formats.common.FormatInfo;
+import org.apache.inlong.sort.formats.common.IntFormatInfo;
+import org.apache.inlong.sort.formats.common.StringFormatInfo;
+import org.apache.flink.api.java.tuple.Tuple2;
+
+import java.io.IOException;
+
+
+public class TestDorisSink {
+ public static void main(String[] args) throws Exception {
+ ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
+ env.setParallelism(1);
+
+
+
+ final DataSource<Tuple2<Boolean, Row>> data = env.fromElements(
+ new Tuple2<Boolean, Row>(true, Row.of(1, "pengpeng", 13)),
+ new Tuple2<Boolean, Row>(true, Row.of(2, "xingxing", 2))
+ );
+
+
+ DorisSinkOptions dorisSinkOptions = new DorisSinkOptionsBuilder()
+ .setFeNodes("10.93.6.6:8030")
Review comment:
it's a reveal address？
##########
File path: inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/flink/doris/TestDorisSink.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.inlong.sort.flink.doris;
+
+import org.apache.flink.api.java.ExecutionEnvironment;
+import org.apache.flink.api.java.operators.DataSource;
+import org.apache.flink.types.Row;
+import org.apache.inlong.sort.flink.doris.output.DorisOutputFormat;
+import org.apache.inlong.sort.formats.common.FormatInfo;
+import org.apache.inlong.sort.formats.common.IntFormatInfo;
+import org.apache.inlong.sort.formats.common.StringFormatInfo;
+import org.apache.flink.api.java.tuple.Tuple2;
+
+import java.io.IOException;
+
+
+public class TestDorisSink {
+ public static void main(String[] args) throws Exception {
+ ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment();
+ env.setParallelism(1);
+
+
+
+ final DataSource<Tuple2<Boolean, Row>> data = env.fromElements(
+ new Tuple2<Boolean, Row>(true, Row.of(1, "pengpeng", 13)),
+ new Tuple2<Boolean, Row>(true, Row.of(2, "xingxing", 2))
+ );
+
+
+ DorisSinkOptions dorisSinkOptions = new DorisSinkOptionsBuilder()
+ .setFeNodes("10.93.6.6:8030")
Review comment:
it's a real address？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] ifndef-SleePy commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
ifndef-SleePy commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-981469171
Hi @huzk8 , thanks for contributing!
It's nice to support Doris sink for INLONG project. It looks good to me although I'm not an expert of Doris. I think it's fine to merge the PR first and to tune it later if necessary.
So +1 for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-982518947
@huzk8, there are several review comments that you need to modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang commented on a change in pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#discussion_r758243921
##########
File path: inlong-sort/sort-core/src/main/java/org/apache/inlong/sort/flink/doris/load/DorisRespond.java
##########
@@ -0,0 +1,42 @@
+package org.apache.inlong.sort.flink.doris.load;
+
+/**
+ * @program: incubator-inlong
Review comment:
After the class function is annotated, the author and creation time need to be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang commented on pull request #1846: [INLONG-810] Sort Module Support store data to ApacheDoris
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #1846:
URL: https://github.com/apache/incubator-inlong/pull/1846#issuecomment-984221518
@huzk8 do you plan to fix the last problems according to the review comments？ We will release the next version in two weeks, and we hope this PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org